Skip to content

Align Linux sandbox names and docs with bubblewrap and seccomp - #52610

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/be4769d5a10b90605990eb58451e83fdf1c31222
Oct 9, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/be4769d5a10b90605990eb58451e83fdf1c31222

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Align Linux sandbox names and docs with bubblewrap and seccomp

Why

The Linux sandbox uses bubblewrap for filesystem isolation and seccomp for syscall filtering, but its command type, syscall-filter module, and integration test suite still used Landlock names.

What changed

  • Rename LandlockCommand to LinuxSandboxCommand, src/landlock.rs to src/seccomp.rs, and tests/suite/landlock.rs to tests/suite/sandbox.rs, updating imports and existing tests.
  • Clarify the retained legacy Landlock implementation and its filesystem-policy limitations.
  • Update the README to describe existing network filtering, AF_VSOCK and io_uring restrictions, and managed-proxy Unix socket behavior, including allowed Unix socket pairs.

Sandbox enforcement behavior is unchanged.

## Why

The Linux sandbox uses bubblewrap for filesystem isolation and seccomp for syscall filtering, but its command type, syscall-filter module, and integration test suite still used Landlock names.

## What changed

- Rename `LandlockCommand` to `LinuxSandboxCommand`, `src/landlock.rs` to `src/seccomp.rs`, and `tests/suite/landlock.rs` to `tests/suite/sandbox.rs`, updating imports and existing tests.
- Clarify the retained legacy Landlock implementation and its filesystem-policy limitations.
- Update the README to describe existing network filtering, `AF_VSOCK` and `io_uring` restrictions, and managed-proxy Unix socket behavior, including allowed Unix socket pairs.

Sandbox enforcement behavior is unchanged.

GitOrigin-RevId: be4769d5a10b90605990eb58451e83fdf1c31222
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/be4769d5a10b90605990eb58451e83fdf1c31222 branch from b4b6141 to c63929a Compare October 9, 2026 15:30
@copyberry
copyberry Bot merged commit c63929a into main Oct 9, 2026
1 check passed
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-09T15:30:03.413192Z b4b6141 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/be4769d5a10b90605990eb58451e83fdf1c31222 branch October 9, 2026 15:30
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 9, 2026
@jacekrejdych
jacekrejdych deployed to issue-triage October 9, 2026 15:33 — with Image GitHub Actions Active
@jacekrejdych
jacekrejdych deployed to issue-triage October 9, 2026 15:33 — with Image GitHub Actions Active
@jacekrejdych
jacekrejdych deployed to issue-triage October 9, 2026 15:33 — with Image GitHub Actions Active
@eli-sterling
eli-sterling deployed to issue-triage October 9, 2026 15:33 — with Image GitHub Actions Active
@eli-sterling
eli-sterling deployed to issue-triage October 9, 2026 15:33 — with Image GitHub Actions Active
@eli-sterling
eli-sterling deployed to issue-triage October 9, 2026 15:33 — with Image GitHub Actions Active
@eli-sterling
eli-sterling deployed to issue-triage October 9, 2026 15:34 — with Image GitHub Actions Active
@vaultboy001
vaultboy001 deployed to issue-triage October 9, 2026 15:37 — with Image GitHub Actions Active
@vaultboy001
vaultboy001 deployed to issue-triage October 9, 2026 15:37 — with Image GitHub Actions Active
@vaultboy001
vaultboy001 deployed to issue-triage October 9, 2026 15:37 — with Image GitHub Actions Active
@diegozea
diegozea deployed to issue-triage October 9, 2026 15:43 — with Image GitHub Actions Active
@diegozea
diegozea deployed to issue-triage October 9, 2026 15:43 — with Image GitHub Actions Active
@diegozea
diegozea deployed to issue-triage October 9, 2026 15:43 — with Image GitHub Actions Active
@chrislsavage
chrislsavage deployed to issue-triage October 9, 2026 16:04 — with Image GitHub Actions Active
@chrislsavage
chrislsavage deployed to issue-triage October 9, 2026 16:04 — with Image GitHub Actions Active
@chrislsavage
chrislsavage deployed to issue-triage October 9, 2026 16:04 — with Image GitHub Actions Active
@junyharang
junyharang deployed to issue-triage October 9, 2026 16:07 — with Image GitHub Actions Active
@junyharang
junyharang deployed to issue-triage October 9, 2026 16:07 — with Image GitHub Actions Active
@junyharang
junyharang deployed to issue-triage October 9, 2026 16:07 — with Image GitHub Actions Active
@junyharang
junyharang deployed to issue-triage October 9, 2026 16:09 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants