Skip to content

Skip background workspace routing reads without ChatGPT auth - #52635

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/8b90ee609ed24f8618cd21f160eb7001703b8bd1
Oct 9, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/8b90ee609ed24f8618cd21f160eb7001703b8bd1

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Skip background workspace routing reads without ChatGPT auth

Why

Background workspace routing reads reload configuration even when signed out or using an API key, although routing requires ChatGPT authentication.

What changed

Check cached authentication before reading accounts for workspace routing at app-server startup and connection initialization. Skip these background reads without ChatGPT authentication, while preserving configuration reloads for explicit account/read requests.

Testing

Add regression tests covering signed-out and API-key startup and connection initialization, explicit account/read configuration reloads, and routing after ChatGPT sign-in, including propagation of configuration errors.

## Why

Background workspace routing reads reload configuration even when signed out or using an API key, although routing requires ChatGPT authentication.

## What changed

Check cached authentication before reading accounts for workspace routing at app-server startup and connection initialization. Skip these background reads without ChatGPT authentication, while preserving configuration reloads for explicit `account/read` requests.

## Testing

Add regression tests covering signed-out and API-key startup and connection initialization, explicit `account/read` configuration reloads, and routing after ChatGPT sign-in, including propagation of configuration errors.

GitOrigin-RevId: 8b90ee609ed24f8618cd21f160eb7001703b8bd1
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/8b90ee609ed24f8618cd21f160eb7001703b8bd1 branch from 80f42dd to 751e7ed Compare October 9, 2026 16:41
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-09T16:41:04.687040Z 80f42dd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit 751e7ed into main Oct 9, 2026
1 check failed
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/8b90ee609ed24f8618cd21f160eb7001703b8bd1 branch October 9, 2026 16:41
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 9, 2026

This branch was successfully deployed

1 active deployment
issue-triage — 751e7edd Deployed Oct 9, 2026 by astromegoracle via Identify potential duplicates (all issues) #53803
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants