Repository navigation
Bound local exec-server output draining after process exit - #52652
Merged
copyberry[bot] merged 1 commit intoOct 9, 2026
Conversation
## Why A local command can exit while a descendant keeps its inherited output pipes open, delaying `exec_command` completion and turn completion. ## What changed Start the bounded output drain when a local exec-server process exits, whether exit is reported by an event or recovered through `process/read`. Remote execution continues waiting for output closure so buffered or delayed output is retained. ## Testing Add regression coverage for local shell snapshot execution completing before a descendant releases stdout, preserving the foreground output and exit code. Add remote event-stream cases that retain output arriving after both reported and recovered process exit. GitOrigin-RevId: d38bcd394be42cf48d2af02733e883b02d1dd62f
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/d38bcd394be42cf48d2af02733e883b02d1dd62f
branch
from
October 9, 2026 17:32
9e2ff42 to
89c8759
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/d38bcd394be42cf48d2af02733e883b02d1dd62f
branch
October 9, 2026 17:32
quantumbitdynamics-collab
deployed
to
issue-triage
October 9, 2026 17:35 — with 
GitHub Actions
Active
GitHub Actions
Active
quantumbitdynamics-collab
deployed
to
issue-triage
October 9, 2026 17:35 — with
GitHub Actions
Active
GitHub Actions
Active
quantumbitdynamics-collab
deployed
to
issue-triage
October 9, 2026 17:35 — with
GitHub Actions
Active
GitHub Actions
Active
quantumbitdynamics-collab
deployed
to
issue-triage
October 9, 2026 17:37 — with
GitHub Actions
Active
GitHub Actions
Active
liuyining20051208-dotcom
deployed
to
issue-triage
October 9, 2026 17:41 — with
GitHub Actions
Active
GitHub Actions
Active
liuyining20051208-dotcom
deployed
to
issue-triage
October 9, 2026 17:41 — with
GitHub Actions
Active
GitHub Actions
Active
liuyining20051208-dotcom
deployed
to
issue-triage
October 9, 2026 17:41 — with
GitHub Actions
Active
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bound local exec-server output draining after process exit
Why
A local command can exit while a descendant keeps its inherited output pipes open, delaying
exec_commandcompletion and turn completion.What changed
Start the bounded output drain when a local exec-server process exits, whether exit is reported by an event or recovered through
process/read. Remote execution continues waiting for output closure so buffered or delayed output is retained.Testing
Add regression coverage for local shell snapshot execution completing before a descendant releases stdout, preserving the foreground output and exit code. Add remote event-stream cases that retain output arriving after both reported and recovered process exit.