Repository navigation
Handle completion events in either order in shell snapshot tests - #52660
Merged
copyberry[bot] merged 1 commit intoOct 9, 2026
Conversation
) ## Why A tool can return before its background watcher emits `ExecCommandEnd`. Waiting for that event first can discard an earlier `TurnComplete`, causing the shell snapshot test helper to time out. ## What changed Update `run_tool_turn_on_harness` to track both the matching `ExecCommandEnd` and `TurnComplete` in a single event loop, returning only after both have arrived regardless of order. GitOrigin-RevId: c9b749a46eda1244aa3e80fd88b663d110d67d1b
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/c9b749a46eda1244aa3e80fd88b663d110d67d1b
branch
from
October 9, 2026 17:56
cbce3ef to
b49e221
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/c9b749a46eda1244aa3e80fd88b663d110d67d1b
branch
October 9, 2026 17:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle completion events in either order in shell snapshot tests
Why
A tool can return before its background watcher emits
ExecCommandEnd. Waiting for that event first can discard an earlierTurnComplete, causing the shell snapshot test helper to time out.What changed
Update
run_tool_turn_on_harnessto track both the matchingExecCommandEndandTurnCompletein a single event loop, returning only after both have arrived regardless of order.