Skip to content

Add retention annotations to submitted tool outputs - #52671

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/7285dde31149b17b0dcf31d4ea1c7cba66d9efe6
Oct 9, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/7285dde31149b17b0dcf31d4ea1c7cba66d9efe6

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Add retention annotations to submitted tool outputs

What changed

Add TurnInput::AnnotatedResponseItem with a caller-supplied retain annotation. For function-call outputs, retain: true sets client_authored history metadata while keeping annotations out of model requests. Accept annotated items through the existing turn submission paths, including continuation.

Testing

Add an integration test covering retention metadata during turn start, steering, idle submission, and rollout storage. Verify that ordinary outputs remain unmarked and model requests contain neither retain nor client_authored.

## What changed

Add `TurnInput::AnnotatedResponseItem` with a caller-supplied `retain` annotation. For function-call outputs, `retain: true` sets `client_authored` history metadata while keeping annotations out of model requests. Accept annotated items through the existing turn submission paths, including continuation.

## Testing

Add an integration test covering retention metadata during turn start, steering, idle submission, and rollout storage. Verify that ordinary outputs remain unmarked and model requests contain neither `retain` nor `client_authored`.

GitOrigin-RevId: 7285dde31149b17b0dcf31d4ea1c7cba66d9efe6
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/7285dde31149b17b0dcf31d4ea1c7cba66d9efe6 branch from 96cb8ef to 04ad786 Compare October 9, 2026 18:36
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-09T18:36:04.644485Z 96cb8ef PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit 04ad786 into main Oct 9, 2026
3 of 6 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/7285dde31149b17b0dcf31d4ea1c7cba66d9efe6 branch October 9, 2026 18:36
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 9, 2026
@kogundal
kogundal deployed to issue-triage October 9, 2026 18:57 — with Image GitHub Actions Active
@kogundal
kogundal deployed to issue-triage October 9, 2026 18:57 — with Image GitHub Actions Active
@kogundal
kogundal deployed to issue-triage October 9, 2026 18:57 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 04ad7869 Deployed Oct 9, 2026 by kogundal via Identify potential duplicates (all issues) #53840
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants