Repository navigation
Reject reserved Serde JSON keys in code mode - #52681
Merged
copyberry[bot] merged 1 commit intoOct 9, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why JavaScript objects containing Serde's reserved JSON keys can be reinterpreted during deserialization, allowing nested `RawValue` markers to bypass the parser's normal recursion limit. ## What changed Reject `$serde_json::private::RawValue` and `$serde_json::private::Number` object keys before passing V8's serialized JSON to `serde_json`. Report a `reserved JSON object key` serialization error while continuing to allow marker text in strings and longer keys. ## Testing Add runtime regression coverage for nested and escaped marker keys, recursion limits, normal JSON conversion, and session recovery without overwriting stored values. Extend the host-backed integration test to verify that stored values remain available across turns after rejection. GitOrigin-RevId: 27ddce08e1ffe98ec9dffe02473a815ceae2cc89
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/27ddce08e1ffe98ec9dffe02473a815ceae2cc89
branch
from
October 9, 2026 19:46
a414ccf to
96be88c
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/27ddce08e1ffe98ec9dffe02473a815ceae2cc89
branch
October 9, 2026 19:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject reserved Serde JSON keys in code mode
Why
JavaScript objects containing Serde's reserved JSON keys can be reinterpreted during deserialization, allowing nested
RawValuemarkers to bypass the parser's normal recursion limit.What changed
Reject
$serde_json::private::RawValueand$serde_json::private::Numberobject keys before passing V8's serialized JSON toserde_json. Report areserved JSON object keyserialization error while continuing to allow marker text in strings and longer keys.Testing
Add runtime regression coverage for nested and escaped marker keys, recursion limits, normal JSON conversion, and session recovery without overwriting stored values. Extend the host-backed integration test to verify that stored values remain available across turns after rejection.