Skip to content

Validate Windows sandbox accounts before password repair - #52682

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/bafedb52cf9bd484250ccac3b163d2041891283f
Oct 9, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/bafedb52cf9bd484250ccac3b163d2041891283f

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Validate Windows sandbox accounts before password repair

Why

A credential mismatch can trigger setup that rotates both sandbox account passwords. Before allowing repair, validate the account that logged on successfully and ensure that neither account has been replaced or has an unowned runtime registration.

What changed

  • Validate runtime records and successful logon tokens, checking account SIDs, rejecting administrators, and requiring enabled CodexSandboxUsers membership.
  • Before repair, verify recorded account SIDs and reject existing same-family package registrations for unrecorded accounts. Propagate package-query failures while allowing initial migration when no registrations exist.

Testing

Add tests for malformed records and unrelated logon errors, plus an ignored disposable Windows Sandbox fixture covering successful logons, group membership, SID changes, migration, and unowned registrations.

## Why

A credential mismatch can trigger setup that rotates both sandbox account passwords. Before allowing repair, validate the account that logged on successfully and ensure that neither account has been replaced or has an unowned runtime registration.

## What changed

- Validate runtime records and successful logon tokens, checking account SIDs, rejecting administrators, and requiring enabled `CodexSandboxUsers` membership.
- Before repair, verify recorded account SIDs and reject existing same-family package registrations for unrecorded accounts. Propagate package-query failures while allowing initial migration when no registrations exist.

## Testing

Add tests for malformed records and unrelated logon errors, plus an ignored disposable Windows Sandbox fixture covering successful logons, group membership, SID changes, migration, and unowned registrations.

GitOrigin-RevId: bafedb52cf9bd484250ccac3b163d2041891283f
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/bafedb52cf9bd484250ccac3b163d2041891283f branch from 508f9f7 to 52950c5 Compare October 9, 2026 19:48
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-09T19:48:51.878106Z 508f9f7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit 52950c5 into main Oct 9, 2026
1 check failed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/bafedb52cf9bd484250ccac3b163d2041891283f branch October 9, 2026 19:48
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 9, 2026
@talraveh1
talraveh1 deployed to issue-triage October 9, 2026 19:56 — with Image GitHub Actions Active
@talraveh1
talraveh1 deployed to issue-triage October 9, 2026 19:56 — with Image GitHub Actions Active
@talraveh1
talraveh1 deployed to issue-triage October 9, 2026 19:56 — with Image GitHub Actions Active
@Manutebi
Manutebi deployed to issue-triage October 9, 2026 19:59 — with Image GitHub Actions Active
@Manutebi
Manutebi deployed to issue-triage October 9, 2026 19:59 — with Image GitHub Actions Active
@Manutebi
Manutebi deployed to issue-triage October 9, 2026 19:59 — with Image GitHub Actions Active

This branch was successfully deployed

2 active deployments
pypi — 52950c59 Deployed Oct 9, 2026 by iceweasel-oai via publish-python-sdk #281
issue-triage — 52950c59 Deployed Oct 9, 2026 by Manutebi via Translate non-English issue #18929
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants