Skip to content

Add opt-in retention for turn tool outputs - #52686

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/52893a8fcb308f26e77ba8f0bee9990073b26d54
Oct 9, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/52893a8fcb308f26e77ba8f0bee9990073b26d54

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Add opt-in retention for turn tool outputs

What changed

Add an optional retain flag to TurnToolOutput for turn/start. When set to true, pass the output to the core with a retention annotation to request retention in the thread's model history. The flag defaults to false, preserving existing behavior.

Update the generated JSON schemas, TypeScript types, and Python bindings to expose the flag.

Testing

Add an integration test verifying that a retained tool output reaches the model and preserves client-authored sender metadata in persisted history, including the receiver message ID.

## What changed

Add an optional `retain` flag to `TurnToolOutput` for `turn/start`. When set to `true`, pass the output to the core with a retention annotation to request retention in the thread's model history. The flag defaults to `false`, preserving existing behavior.

Update the generated JSON schemas, TypeScript types, and Python bindings to expose the flag.

## Testing

Add an integration test verifying that a retained tool output reaches the model and preserves client-authored sender metadata in persisted history, including the receiver message ID.

GitOrigin-RevId: 52893a8fcb308f26e77ba8f0bee9990073b26d54
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/52893a8fcb308f26e77ba8f0bee9990073b26d54 branch from 31ebc6d to 4531135 Compare October 9, 2026 20:02
@copyberry
copyberry Bot merged commit 4531135 into main Oct 9, 2026
1 check passed
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-09T20:02:31.966062Z 31ebc6d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/52893a8fcb308f26e77ba8f0bee9990073b26d54 branch October 9, 2026 20:02
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 9, 2026
@sishuaigong
sishuaigong deployed to issue-triage October 9, 2026 20:13 — with Image GitHub Actions Active
@sishuaigong
sishuaigong deployed to issue-triage October 9, 2026 20:13 — with Image GitHub Actions Active
@sishuaigong
sishuaigong deployed to issue-triage October 9, 2026 20:13 — with Image GitHub Actions Active
@mgrant0
mgrant0 deployed to issue-triage October 9, 2026 20:14 — with Image GitHub Actions Active
@mgrant0
mgrant0 deployed to issue-triage October 9, 2026 20:14 — with Image GitHub Actions Active
@mgrant0
mgrant0 deployed to issue-triage October 9, 2026 20:14 — with Image GitHub Actions Active
@sishuaigong
sishuaigong deployed to issue-triage October 9, 2026 20:14 — with Image GitHub Actions Active
@mgrant0
mgrant0 deployed to issue-triage October 9, 2026 20:15 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants