Skip to content

Fix marketplace path matching for Windows junctions - #52696

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/f1ae46e8e7384075ed1baa6b33b2821f795e17f8
Oct 9, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/f1ae46e8e7384075ed1baa6b33b2821f795e17f8

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Fix marketplace path matching for Windows junctions

Why

Equivalent local source paths can fail to match an already-added marketplace, and redirected managed roots can lose their managed classification on Windows.

What changed

  • Compare local marketplace sources after filesystem normalization.
  • Reuse the resolved request path when locating an existing local marketplace so retargeting a configured junction does not switch the returned root.
  • Accept both the configured managed root and its canonical target on Windows while continuing to reject unowned aliases to that target.

Testing

Add Windows regression tests for canonical and legacy path spellings, retargeted local-source junctions, and redirected managed roots with unowned aliases.

## Why

Equivalent local source paths can fail to match an already-added marketplace, and redirected managed roots can lose their managed classification on Windows.

## What changed

- Compare local marketplace sources after filesystem normalization.
- Reuse the resolved request path when locating an existing local marketplace so retargeting a configured junction does not switch the returned root.
- Accept both the configured managed root and its canonical target on Windows while continuing to reject unowned aliases to that target.

## Testing

Add Windows regression tests for canonical and legacy path spellings, retargeted local-source junctions, and redirected managed roots with unowned aliases.

GitOrigin-RevId: f1ae46e8e7384075ed1baa6b33b2821f795e17f8
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/f1ae46e8e7384075ed1baa6b33b2821f795e17f8 branch from e150bb3 to 2f761ae Compare October 9, 2026 20:36
@copyberry
copyberry Bot merged commit 2f761ae into main Oct 9, 2026
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/f1ae46e8e7384075ed1baa6b33b2821f795e17f8 branch October 9, 2026 20:36
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 9, 2026
@roshyrowe
roshyrowe deployed to issue-triage October 9, 2026 20:45 — with Image GitHub Actions Active
@roshyrowe
roshyrowe deployed to issue-triage October 9, 2026 20:45 — with Image GitHub Actions Active
@roshyrowe
roshyrowe deployed to issue-triage October 9, 2026 20:45 — with Image GitHub Actions Active
@roshyrowe
roshyrowe deployed to issue-triage October 9, 2026 20:47 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 2f761ae8 Deployed Oct 9, 2026 by malici0us-link via Identify potential duplicates (all issues) #53860
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants