Repository navigation
Retry bootstrap GETs through the system proxy after request failures - #52702
Merged
copyberry[bot] merged 1 commit intoOct 9, 2026
Conversation
…52702) ## Why Account discovery and cloud configuration GETs can fail after connecting but before receiving response headers. These request failures previously bypassed system proxy fallback. ## What changed Allow bootstrap GETs to retry through the system proxy on request errors, alongside the existing connection failure and timeout cases, when fallback is enabled. ## Testing Add regression coverage for connections closed before response headers on `accounts/check` and `config/bundle`, verifying successful proxy retries with the original request headers. Extend coverage to ensure HTTP responses with status `401`, `403`, `407`, `429`, or `503` do not trigger fallback, and network policy denials prevent requests to both the origin and proxy. GitOrigin-RevId: ac34c3bcfe3bd81c905a7e616d8b821879fbe2c9
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/ac34c3bcfe3bd81c905a7e616d8b821879fbe2c9
branch
from
October 9, 2026 21:29
118975d to
4bc83aa
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/ac34c3bcfe3bd81c905a7e616d8b821879fbe2c9
branch
October 9, 2026 21:29
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry bootstrap GETs through the system proxy after request failures
Why
Account discovery and cloud configuration GETs can fail after connecting but before receiving response headers. These request failures previously bypassed system proxy fallback.
What changed
Allow bootstrap GETs to retry through the system proxy on request errors, alongside the existing connection failure and timeout cases, when fallback is enabled.
Testing
Add regression coverage for connections closed before response headers on
accounts/checkandconfig/bundle, verifying successful proxy retries with the original request headers. Extend coverage to ensure HTTP responses with status401,403,407,429, or503do not trigger fallback, and network policy denials prevent requests to both the origin and proxy.