Repository navigation
Add observers for initial exec-server connection attempts - #52724
Merged
copyberry[bot] merged 1 commit intoOct 9, 2026
Conversation
## What changed Expose `Environment::observe_connection_attempts` and `ConnectionAttemptOutcome` to report elapsed time and success, failure, or cancellation for initial connections. Measure from the end of provisioning through client installation, including connection retries. The first registered observer wins. Past attempts and reconnections are omitted. ## Testing Extend tests to assert failure followed by success when startup is retried, and a single cancellation notification when an environment is replaced during startup. GitOrigin-RevId: 88300f38dcf9428b824c5ff36aa1b40d7d466b6f
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/88300f38dcf9428b824c5ff36aa1b40d7d466b6f
branch
from
October 9, 2026 23:28
d630910 to
7efd184
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/88300f38dcf9428b824c5ff36aa1b40d7d466b6f
branch
October 9, 2026 23:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add observers for initial exec-server connection attempts
What changed
Expose
Environment::observe_connection_attemptsandConnectionAttemptOutcometo report elapsed time and success, failure, or cancellation for initial connections. Measure from the end of provisioning through client installation, including connection retries.The first registered observer wins. Past attempts and reconnections are omitted.
Testing
Extend tests to assert failure followed by success when startup is retried, and a single cancellation notification when an environment is replaced during startup.