Repository navigation
Reduce stack usage in async TUI tests - #52959
Merged
copyberry[bot] merged 1 commit intoOct 10, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Large test futures can occupy their caller's stack frame even when passed directly to `Box::pin`. ## What changed - Add a non-inlined `box_future` helper and `boxed_future!` macro to construct and box futures outside the caller's poll frame. Use them for heavyweight TUI fixtures and test scenarios. - Return the shared `App` fixture as `Box<App>` to keep it on the heap. - Treat `ConnectionAborted` as a closed connection in the realtime speech test server, alongside `BrokenPipe` and `ConnectionReset`. GitOrigin-RevId: 7bbf2020a5ec12bae8e0365ddf5641deef93b544
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/7bbf2020a5ec12bae8e0365ddf5641deef93b544
branch
from
October 10, 2026 18:50
ece5c23 to
47bcb3a
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/7bbf2020a5ec12bae8e0365ddf5641deef93b544
branch
October 10, 2026 18:50
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce stack usage in async TUI tests
Why
Large test futures can occupy their caller's stack frame even when passed directly to
Box::pin.What changed
box_futurehelper andboxed_future!macro to construct and box futures outside the caller's poll frame. Use them for heavyweight TUI fixtures and test scenarios.Appfixture asBox<App>to keep it on the heap.ConnectionAbortedas a closed connection in the realtime speech test server, alongsideBrokenPipeandConnectionReset.