Repository navigation
Handle broken pipes gracefully in plugin list output - #53109
Merged
copyberry[bot] merged 1 commit intoOct 11, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Piping `codex plugin list` into a consumer such as `head` can close stdout before the full catalog is written, causing a panic. ## What changed Write both table and JSON output through a fallible writer and treat broken pipes during writing or flushing as success. Continue propagating other output errors. ## Testing Add unit tests for write and flush failures in both output formats, plus CLI tests that close stdout early and verify a successful exit without a panic. GitOrigin-RevId: cc4a64e10ad723d26b6de9e731efdc534dbee492
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/cc4a64e10ad723d26b6de9e731efdc534dbee492
branch
from
October 11, 2026 12:38
1e3bcc7 to
a07c8eb
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/cc4a64e10ad723d26b6de9e731efdc534dbee492
branch
October 11, 2026 12:38
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle broken pipes gracefully in plugin list output
Why
Piping
codex plugin listinto a consumer such asheadcan close stdout before the full catalog is written, causing a panic.What changed
Write both table and JSON output through a fallible writer and treat broken pipes during writing or flushing as success. Continue propagating other output errors.
Testing
Add unit tests for write and flush failures in both output formats, plus CLI tests that close stdout early and verify a successful exit without a panic.