Repository navigation
Keep remote app-server events deliverable during shutdown - #53155
Merged
copyberry[bot] merged 1 commit intoOct 11, 2026
Conversation
## Why Dropping the event receiver before shutdown lets an in-flight notification fail delivery and terminate the worker before it sends the WebSocket close frame. ## What changed Keep the event receiver alive until `RemoteAppServerClient::shutdown` finishes waiting for the worker, allowing it to process the shutdown command and close the WebSocket. ## Testing Extend regression tests to verify that an event remains deliverable after shutdown is queued and that the server receives `Message::Close(None)` with an extra notification in flight. GitOrigin-RevId: ba14bc97ffa3453b7b59660144db6da9e688983d
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/ba14bc97ffa3453b7b59660144db6da9e688983d
branch
from
October 11, 2026 15:57
13676e3 to
95db2cd
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/ba14bc97ffa3453b7b59660144db6da9e688983d
branch
October 11, 2026 15:57
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep remote app-server events deliverable during shutdown
Why
Dropping the event receiver before shutdown lets an in-flight notification fail delivery and terminate the worker before it sends the WebSocket close frame.
What changed
Keep the event receiver alive until
RemoteAppServerClient::shutdownfinishes waiting for the worker, allowing it to process the shutdown command and close the WebSocket.Testing
Extend regression tests to verify that an event remains deliverable after shutdown is queued and that the server receives
Message::Close(None)with an extra notification in flight.