Repository navigation
Simplify the custom terminal drawing API - #53156
Merged
copyberry[bot] merged 1 commit intoOct 11, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## What changed Remove `Terminal::autoresize` and the fallible `try_draw` helpers. Render directly in `draw_with_size`, retaining automatic size updates and the existing buffer flush and cursor handling. Update the cursor-ordering test to use `draw`, preserving its assertion that the cursor moves before it is shown. GitOrigin-RevId: 5889e9603d772945660e7ae35690d2b7326b10ae
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/5889e9603d772945660e7ae35690d2b7326b10ae
branch
from
October 11, 2026 16:03
b2271d5 to
72f999e
Compare
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/5889e9603d772945660e7ae35690d2b7326b10ae
branch
October 11, 2026 16:03
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the custom terminal drawing API
What changed
Remove
Terminal::autoresizeand the fallibletry_drawhelpers. Render directly indraw_with_size, retaining automatic size updates and the existing buffer flush and cursor handling.Update the cursor-ordering test to use
draw, preserving its assertion that the cursor moves before it is shown.