Skip to content

Keep agents navigation available after a thread is archived - #53201

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/a3f36b42bafee948ed7f5842fcb425e414d7e024
Oct 11, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/a3f36b42bafee948ed7f5842fcb425e414d7e024

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Keep agents navigation available after a thread is archived

Why

After a thread was archived externally, the TUI still advertised the Left-arrow agents shortcut, but pressing it in an empty composer did not open the agents view.

What changed

Reuse the agents navigation handler when connected to an unavailable thread. Preserve the existing empty-composer and editor guards, and require a key press so repeated Left-arrow events do not open the view.

Testing

Add a regression test for external thread archiving that verifies draft editing, the shortcut hint, ignored key repeats, and opening the agents command center, with a snapshot of the resulting view.

## Why

After a thread was archived externally, the TUI still advertised the Left-arrow agents shortcut, but pressing it in an empty composer did not open the agents view.

## What changed

Reuse the agents navigation handler when connected to an unavailable thread. Preserve the existing empty-composer and editor guards, and require a key press so repeated Left-arrow events do not open the view.

## Testing

Add a regression test for external thread archiving that verifies draft editing, the shortcut hint, ignored key repeats, and opening the agents command center, with a snapshot of the resulting view.

GitOrigin-RevId: a3f36b42bafee948ed7f5842fcb425e414d7e024
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/a3f36b42bafee948ed7f5842fcb425e414d7e024 branch from 6cad509 to 9f3d255 Compare October 11, 2026 20:46
@copyberry
copyberry Bot merged commit 9f3d255 into main Oct 11, 2026
12 of 18 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-11T20:46:10.370248Z 9f3d255 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/a3f36b42bafee948ed7f5842fcb425e414d7e024 branch October 11, 2026 20:46
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 11, 2026
@vhmassu
vhmassu deployed to issue-triage October 11, 2026 20:50 — with Image GitHub Actions Active
@vhmassu
vhmassu deployed to issue-triage October 11, 2026 20:50 — with Image GitHub Actions Active
@vhmassu
vhmassu deployed to issue-triage October 11, 2026 20:50 — with Image GitHub Actions Active
@gitcrhub
gitcrhub deployed to issue-triage October 11, 2026 21:03 — with Image GitHub Actions Active
@gitcrhub
gitcrhub deployed to issue-triage October 11, 2026 21:03 — with Image GitHub Actions Active
@gitcrhub
gitcrhub deployed to issue-triage October 11, 2026 21:03 — with Image GitHub Actions Active
@gitcrhub
gitcrhub deployed to issue-triage October 11, 2026 21:04 — with Image GitHub Actions Active
@ampeck94
ampeck94 deployed to issue-triage October 11, 2026 21:12 — with Image GitHub Actions Active
@ampeck94
ampeck94 deployed to issue-triage October 11, 2026 21:12 — with Image GitHub Actions Active
@ampeck94
ampeck94 deployed to issue-triage October 11, 2026 21:12 — with Image GitHub Actions Active
@ampeck94
ampeck94 deployed to issue-triage October 11, 2026 21:13 — with Image GitHub Actions Active
@jaysp32137
jaysp32137 deployed to issue-triage October 11, 2026 21:16 — with Image GitHub Actions Active
@jaysp32137
jaysp32137 deployed to issue-triage October 11, 2026 21:16 — with Image GitHub Actions Active
@jaysp32137
jaysp32137 deployed to issue-triage October 11, 2026 21:16 — with Image GitHub Actions Active
@Chipolitos
Chipolitos deployed to issue-triage October 11, 2026 21:22 — with Image GitHub Actions Active
@Chipolitos
Chipolitos deployed to issue-triage October 11, 2026 21:22 — with Image GitHub Actions Active
@Chipolitos
Chipolitos deployed to issue-triage October 11, 2026 21:22 — with Image GitHub Actions Active
@Chipolitos
Chipolitos deployed to issue-triage October 11, 2026 21:23 — with Image GitHub Actions Active
@OrcaWin
OrcaWin deployed to issue-triage October 11, 2026 21:44 — with Image GitHub Actions Active
@OrcaWin
OrcaWin deployed to issue-triage October 11, 2026 21:44 — with Image GitHub Actions Active
@OrcaWin
OrcaWin deployed to issue-triage October 11, 2026 21:44 — with Image GitHub Actions Active
@vavanv
vavanv deployed to issue-triage October 11, 2026 22:05 — with Image GitHub Actions Active
@vavanv
vavanv deployed to issue-triage October 11, 2026 22:05 — with Image GitHub Actions Active
@vavanv
vavanv deployed to issue-triage October 11, 2026 22:05 — with Image GitHub Actions Active
@vavanv
vavanv deployed to issue-triage October 11, 2026 22:06 — with Image GitHub Actions Active
@rodcript
rodcript deployed to issue-triage October 11, 2026 22:11 — with Image GitHub Actions Active
@rodcript
rodcript deployed to issue-triage October 11, 2026 22:11 — with Image GitHub Actions Active
@rodcript
rodcript deployed to issue-triage October 11, 2026 22:11 — with Image GitHub Actions Active
@sampotts
sampotts deployed to issue-triage October 11, 2026 22:25 — with Image GitHub Actions Active
@sampotts
sampotts deployed to issue-triage October 11, 2026 22:25 — with Image GitHub Actions Active
@sampotts
sampotts deployed to issue-triage October 11, 2026 22:25 — with Image GitHub Actions Active
@sampotts
sampotts deployed to issue-triage October 11, 2026 22:26 — with Image GitHub Actions Active
@RazeBerry
RazeBerry deployed to issue-triage October 11, 2026 22:34 — with Image GitHub Actions Active
@RazeBerry
RazeBerry deployed to issue-triage October 11, 2026 22:34 — with Image GitHub Actions Active
@RazeBerry
RazeBerry deployed to issue-triage October 11, 2026 22:34 — with Image GitHub Actions Active
@RazeBerry
RazeBerry deployed to issue-triage October 11, 2026 22:35 — with Image GitHub Actions Active
@bpa-eng
bpa-eng deployed to issue-triage October 11, 2026 22:59 — with Image GitHub Actions Active
@bpa-eng
bpa-eng deployed to issue-triage October 11, 2026 22:59 — with Image GitHub Actions Active
@bpa-eng
bpa-eng deployed to issue-triage October 11, 2026 22:59 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 9f3d2558 Deployed Oct 11, 2026 by rafaself via Identify potential duplicates (open issues fallback) #54522
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.