Repository navigation
Support Windows clipboard text paste shortcuts in the TUI - #53224
Merged
copyberry[bot] merged 1 commit intoOct 11, 2026
Conversation
## Why `Ctrl+V` previously attempted only image paste, so a text-only clipboard produced an image-paste error. `Shift+Insert` did not use the clipboard paste path. ## What changed - On Windows, let `Ctrl+V` and `Shift+Insert` paste images first, then read clipboard text asynchronously when no image is available. Keep clipboard access errors distinct from missing images. - Allow keyboard paste into composer selections and active history or Vim search queries, including inline mode with right-click paste disabled. - Flush buffered typing before explicit paste to preserve input order. Discard pending clipboard text when the thread or editable target changes, while allowing shortcut releases and repeated paste shortcuts to leave the read pending. ## Testing Extend shortcut and clipboard-worker tests to cover text fallback, multiline Unicode text, stale-read cancellation, shortcut releases and repeats, and read-only drafts. Add assertions for history-search preview stability and selection changes. GitOrigin-RevId: 080c1c05a4587e325cea938a6e28c646b9ac5837
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/080c1c05a4587e325cea938a6e28c646b9ac5837
branch
from
October 11, 2026 23:44
70e7cc9 to
a9b0815
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/080c1c05a4587e325cea938a6e28c646b9ac5837
branch
October 11, 2026 23:45
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Windows clipboard text paste shortcuts in the TUI
Why
Ctrl+Vpreviously attempted only image paste, so a text-only clipboard produced an image-paste error.Shift+Insertdid not use the clipboard paste path.What changed
Ctrl+VandShift+Insertpaste images first, then read clipboard text asynchronously when no image is available. Keep clipboard access errors distinct from missing images.Testing
Extend shortcut and clipboard-worker tests to cover text fallback, multiline Unicode text, stale-read cancellation, shortcut releases and repeats, and read-only drafts. Add assertions for history-search preview stability and selection changes.