Repository navigation
Use cached login credentials for Guardian decisions - #53389
Merged
copyberry[bot] merged 1 commit intoOct 12, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Reading `OPENAI_API_KEY` directly bypasses login credentials reloaded by `AuthManager`. ## What changed Use the API key from `AuthManager`'s cached authentication for Guardian decisions when the provider is `openai` and has no custom base URL. Keep `CODEX_GUARDIAN_DECISIONS_API_KEY` as the highest-priority override. ## Testing Add a regression test covering a reloaded API-key login, override precedence, and rejection of the login-key fallback for a custom base URL. Assertions avoid printing credentials on failure. GitOrigin-RevId: 10b2e6c28d3268c3808c25b2be94d9b6c31f597a
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/10b2e6c28d3268c3808c25b2be94d9b6c31f597a
branch
from
October 12, 2026 14:08
7fe31af to
27e6192
Compare
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/10b2e6c28d3268c3808c25b2be94d9b6c31f597a
branch
October 12, 2026 14:08
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Chat-Media
had a problem deploying
to
issue-triage
October 12, 2026 14:15 — with
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use cached login credentials for Guardian decisions
Why
Reading
OPENAI_API_KEYdirectly bypasses login credentials reloaded byAuthManager.What changed
Use the API key from
AuthManager's cached authentication for Guardian decisions when the provider isopenaiand has no custom base URL. KeepCODEX_GUARDIAN_DECISIONS_API_KEYas the highest-priority override.Testing
Add a regression test covering a reloaded API-key login, override precedence, and rejection of the login-key fallback for a custom base URL. Assertions avoid printing credentials on failure.