Skip to content

Distinguish Guardian parent-compaction failure reasons - #53393

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/103c4173b2ebbdc33eb71bce7f8ecb56f73055f6
Oct 12, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/103c4173b2ebbdc33eb71bce7f8ecb56f73055f6

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Distinguish Guardian parent-compaction failure reasons

Why

The generic parent_compaction_error classification metric does not distinguish serialization failures, oversized compactions, and unusable compactions.

What changed

Record separate failure_reason values for each case: parent_compaction_serialization, parent_compaction_oversized, and parent_compaction_unusable.

Testing

Extend parent-compaction reuse tests to cover unusable checkpoints in parent-context mode and assert specific failure reasons. Verify rejected compactions receive the maximum risk score, provide no cached approval, and do not reuse stale context.

## Why

The generic `parent_compaction_error` classification metric does not distinguish serialization failures, oversized compactions, and unusable compactions.

## What changed

Record separate `failure_reason` values for each case: `parent_compaction_serialization`, `parent_compaction_oversized`, and `parent_compaction_unusable`.

## Testing

Extend parent-compaction reuse tests to cover unusable checkpoints in parent-context mode and assert specific failure reasons. Verify rejected compactions receive the maximum risk score, provide no cached approval, and do not reuse stale context.

GitOrigin-RevId: 103c4173b2ebbdc33eb71bce7f8ecb56f73055f6
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/103c4173b2ebbdc33eb71bce7f8ecb56f73055f6 branch from c2af05e to cab328f Compare October 12, 2026 14:16
@copyberry
copyberry Bot merged commit cab328f into main Oct 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/103c4173b2ebbdc33eb71bce7f8ecb56f73055f6 branch October 12, 2026 14:16
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 12, 2026
@guubrzx
guubrzx deployed to issue-triage October 12, 2026 14:22 — with Image GitHub Actions Active
@guubrzx
guubrzx deployed to issue-triage October 12, 2026 14:22 — with Image GitHub Actions Active
@guubrzx
guubrzx deployed to issue-triage October 12, 2026 14:22 — with Image GitHub Actions Active
@guubrzx
guubrzx deployed to issue-triage October 12, 2026 14:23 — with Image GitHub Actions Active
@qqq707
qqq707 deployed to issue-triage October 12, 2026 14:32 — with Image GitHub Actions Active
@qqq707
qqq707 deployed to issue-triage October 12, 2026 14:32 — with Image GitHub Actions Active
@qqq707
qqq707 deployed to issue-triage October 12, 2026 14:32 — with Image GitHub Actions Active
@yurgon79
yurgon79 deployed to issue-triage October 12, 2026 14:36 — with Image GitHub Actions Active
@yurgon79
yurgon79 deployed to issue-triage October 12, 2026 14:36 — with Image GitHub Actions Active
@yurgon79
yurgon79 deployed to issue-triage October 12, 2026 14:36 — with Image GitHub Actions Active
@yurgon79
yurgon79 deployed to issue-triage October 12, 2026 14:37 — with Image GitHub Actions Active
@vladrudn
vladrudn deployed to issue-triage October 12, 2026 14:38 — with Image GitHub Actions Active
@vladrudn
vladrudn deployed to issue-triage October 12, 2026 14:38 — with Image GitHub Actions Active
@vladrudn
vladrudn deployed to issue-triage October 12, 2026 14:38 — with Image GitHub Actions Active
@vladrudn
vladrudn deployed to issue-triage October 12, 2026 14:39 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — cab328f2 Deployed Oct 12, 2026 by vladrudn via Identify potential duplicates (open issues fallback) #54759
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants