Skip to content

Isolate arg0 helper directories by operating system - #53412

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/f34292748b5b1d3c25629604d849db4b133dfa3a
Oct 12, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/f34292748b5b1d3c25629604d849db4b133dfa3a

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Isolate arg0 helper directories by operating system

Why

Windows and WSL can share CODEX_HOME without sharing a lock namespace, allowing cleanup to remove another platform's live helpers. Older clients can also clean helpers stored under the shared tmp/arg0 root.

What changed

Create helpers under CODEX_HOME/tmp/arg0-<os> and limit stale-directory cleanup to that operating system's root. Keep permission discovery compatible with both the current platform's root and legacy tmp/arg0 directories, while ignoring other platforms' aliases.

Testing

Add regression coverage for cleanup isolation, live helper preservation during legacy cleanup, and selection of the first session alias directory from either supported root.

## Why

Windows and WSL can share `CODEX_HOME` without sharing a lock namespace, allowing cleanup to remove another platform's live helpers. Older clients can also clean helpers stored under the shared `tmp/arg0` root.

## What changed

Create helpers under `CODEX_HOME/tmp/arg0-<os>` and limit stale-directory cleanup to that operating system's root. Keep permission discovery compatible with both the current platform's root and legacy `tmp/arg0` directories, while ignoring other platforms' aliases.

## Testing

Add regression coverage for cleanup isolation, live helper preservation during legacy cleanup, and selection of the first session alias directory from either supported root.

GitOrigin-RevId: f34292748b5b1d3c25629604d849db4b133dfa3a
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/f34292748b5b1d3c25629604d849db4b133dfa3a branch from a8d886a to 16845bb Compare October 12, 2026 15:43
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-12T15:43:38.852370Z a8d886a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit 16845bb into main Oct 12, 2026
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/f34292748b5b1d3c25629604d849db4b133dfa3a branch October 12, 2026 15:43
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 12, 2026
@VirgilMing
VirgilMing deployed to issue-triage October 12, 2026 15:59 — with Image GitHub Actions Active
@VirgilMing
VirgilMing deployed to issue-triage October 12, 2026 15:59 — with Image GitHub Actions Active
@VirgilMing
VirgilMing deployed to issue-triage October 12, 2026 15:59 — with Image GitHub Actions Active
@VirgilMing
VirgilMing deployed to issue-triage October 12, 2026 16:00 — with Image GitHub Actions Active
@igalmodas
igalmodas deployed to issue-triage October 12, 2026 16:08 — with Image GitHub Actions Active
@igalmodas
igalmodas deployed to issue-triage October 12, 2026 16:08 — with Image GitHub Actions Active
@igalmodas
igalmodas deployed to issue-triage October 12, 2026 16:08 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 16845bb8 Deployed Oct 12, 2026 by igalmodas via Translate non-English issue #19606
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants