Skip to content

Preserve Windows runtime registration failure diagnostics - #53426

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/7f3a46741304ef04f5c3e2aa575bcfc4392dff62
Oct 12, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/7f3a46741304ef04f5c3e2aa575bcfc4392dff62

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Preserve Windows runtime registration failure diagnostics

Why

Managed runtime package registration errors lacked the terminal status, separate async and deployment error codes, and deployment activity ID needed to diagnose failures.

What changed

Include these diagnostics in registration errors and distinguish failures in GetResults, the ExtendedErrorCode getter, and deployment itself. Preserve the original completion error; failures to read diagnostic fields do not turn successful registration into failure. Keep free-form Windows error text out of diagnostic summaries.

Testing

Add unit tests for distinct async and deployment errors, failed or canceled result retrieval, and diagnostic getter failures, including preservation of native error codes and omission of free-form diagnostic text.

## Why

Managed runtime package registration errors lacked the terminal status, separate async and deployment error codes, and deployment activity ID needed to diagnose failures.

## What changed

Include these diagnostics in registration errors and distinguish failures in `GetResults`, the `ExtendedErrorCode` getter, and deployment itself. Preserve the original completion error; failures to read diagnostic fields do not turn successful registration into failure. Keep free-form Windows error text out of diagnostic summaries.

## Testing

Add unit tests for distinct async and deployment errors, failed or canceled result retrieval, and diagnostic getter failures, including preservation of native error codes and omission of free-form diagnostic text.

GitOrigin-RevId: 7f3a46741304ef04f5c3e2aa575bcfc4392dff62
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/7f3a46741304ef04f5c3e2aa575bcfc4392dff62 branch from 8b0c679 to f605162 Compare October 12, 2026 16:58
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-12T16:58:35.696398Z 8b0c679 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit f605162 into main Oct 12, 2026
1 of 2 checks passed
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/7f3a46741304ef04f5c3e2aa575bcfc4392dff62 branch October 12, 2026 16:58
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 12, 2026
@ellahyyan
ellahyyan deployed to issue-triage October 12, 2026 17:06 — with Image GitHub Actions Active
@ellahyyan
ellahyyan deployed to issue-triage October 12, 2026 17:06 — with Image GitHub Actions Active
@ellahyyan
ellahyyan deployed to issue-triage October 12, 2026 17:06 — with Image GitHub Actions Active
@ellahyyan
ellahyyan deployed to issue-triage October 12, 2026 17:07 — with Image GitHub Actions Active
@ACTheLK
ACTheLK deployed to issue-triage October 12, 2026 17:10 — with Image GitHub Actions Active
@ACTheLK
ACTheLK deployed to issue-triage October 12, 2026 17:10 — with Image GitHub Actions Active
@ACTheLK
ACTheLK deployed to issue-triage October 12, 2026 17:10 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — f6051623 Deployed Oct 12, 2026 by ACTheLK via Translate non-English issue #19613
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants