Repository navigation
Stop identifying Apple Terminal from TERM_SESSION_ID - #53438
Merged
copyberry[bot] merged 1 commit intoOct 12, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why `TERM_SESSION_ID` is not specific to Apple Terminal. Treating it as an Apple Terminal identifier can mask Windows Terminal detection and the `TERM` fallback. ## What changed Remove the `TERM_SESSION_ID` detection heuristic. Apple Terminal remains detectable through `TERM_PROGRAM=Apple_Terminal`. ## Testing Update tests to cover Windows Terminal detection and the `TERM` fallback when `TERM_SESSION_ID` is present, and Apple Terminal detection with its version and user-agent token. GitOrigin-RevId: 27db11cb7bcca8f94888f9e21a6cdfcf31561b1b
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/27db11cb7bcca8f94888f9e21a6cdfcf31561b1b
branch
from
October 12, 2026 17:52
820e005 to
7c1b64c
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/27db11cb7bcca8f94888f9e21a6cdfcf31561b1b
branch
October 12, 2026 17:52
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop identifying Apple Terminal from
TERM_SESSION_IDWhy
TERM_SESSION_IDis not specific to Apple Terminal. Treating it as an Apple Terminal identifier can mask Windows Terminal detection and theTERMfallback.What changed
Remove the
TERM_SESSION_IDdetection heuristic. Apple Terminal remains detectable throughTERM_PROGRAM=Apple_Terminal.Testing
Update tests to cover Windows Terminal detection and the
TERMfallback whenTERM_SESSION_IDis present, and Apple Terminal detection with its version and user-agent token.