Skip to content

Preserve status line accents on 16-color terminals - #53440

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/213ca5c6c366f0a3c696aab256a0b146558a2837
Oct 12, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/213ca5c6c366f0a3c696aab256a0b146558a2837

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Preserve status line accents on 16-color terminals

Why

RGB and extended indexed theme colors cannot be displayed directly on 16-color terminals, causing status line items to lose their color accents.

What changed

Use each status line item's existing ANSI fallback accent when its theme foreground requires RGB or an indexed color beyond the first 16 colors.

Testing

Add regression coverage for uncolored output with FORCE_COLOR=0 and ANSI status line accents with FORCE_COLOR=1. Give the RGB styling test explicit terminal colors so it consistently exercises true-color behavior.

## Why

RGB and extended indexed theme colors cannot be displayed directly on 16-color terminals, causing status line items to lose their color accents.

## What changed

Use each status line item's existing ANSI fallback accent when its theme foreground requires RGB or an indexed color beyond the first 16 colors.

## Testing

Add regression coverage for uncolored output with `FORCE_COLOR=0` and ANSI status line accents with `FORCE_COLOR=1`. Give the RGB styling test explicit terminal colors so it consistently exercises true-color behavior.

GitOrigin-RevId: 213ca5c6c366f0a3c696aab256a0b146558a2837
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/213ca5c6c366f0a3c696aab256a0b146558a2837 branch from f1c1e96 to 6c7d409 Compare October 12, 2026 18:00
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-12T18:00:36.672537Z f1c1e96 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit 6c7d409 into main Oct 12, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/213ca5c6c366f0a3c696aab256a0b146558a2837 branch October 12, 2026 18:00
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 12, 2026
@D4ttara
D4ttara deployed to issue-triage October 12, 2026 18:05 — with Image GitHub Actions Active
@D4ttara
D4ttara deployed to issue-triage October 12, 2026 18:05 — with Image GitHub Actions Active
@D4ttara
D4ttara deployed to issue-triage October 12, 2026 18:05 — with Image GitHub Actions Active
@D4ttara
D4ttara deployed to issue-triage October 12, 2026 18:13 — with Image GitHub Actions Active
@IZKP
IZKP deployed to issue-triage October 12, 2026 18:17 — with Image GitHub Actions Active
@IZKP
IZKP deployed to issue-triage October 12, 2026 18:17 — with Image GitHub Actions Active
@IZKP
IZKP deployed to issue-triage October 12, 2026 18:17 — with Image GitHub Actions Active
@IZKP
IZKP deployed to issue-triage October 12, 2026 18:18 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 6c7d409a Deployed Oct 12, 2026 by IZKP via Identify potential duplicates (open issues fallback) #54811
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants