Repository navigation
Use local MSVC toolchains for native Windows Bazel tests - #53443
Merged
copyberry[bot] merged 1 commit intoOct 12, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Hermetic LLVM targets the GNU ABI on Windows even when an MSVC platform is selected. Native MSVC builds need the runner's MSVC toolchains and SDK environment. ## What changed - Register the local x64 and ARM64 C++ toolchains in `ci-windows-msvc`. - Apply `--config=ci-windows-msvc` to the native Windows Bazel test job. - Allow the native Windows test job to run on `workflow_dispatch` as well as pushes to `main` so toolchain changes can be tested manually. GitOrigin-RevId: b9fbd3f2bba8a3a8bf226cafda19a921c8738acd
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/b9fbd3f2bba8a3a8bf226cafda19a921c8738acd
branch
from
October 12, 2026 18:20
4a688fe to
3ece80b
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/b9fbd3f2bba8a3a8bf226cafda19a921c8738acd
branch
October 12, 2026 18:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use local MSVC toolchains for native Windows Bazel tests
Why
Hermetic LLVM targets the GNU ABI on Windows even when an MSVC platform is selected. Native MSVC builds need the runner's MSVC toolchains and SDK environment.
What changed
ci-windows-msvc.--config=ci-windows-msvcto the native Windows Bazel test job.workflow_dispatchas well as pushes tomainso toolchain changes can be tested manually.