Repository navigation
Reject duplicate Host headers in the network proxy - #53506
Merged
copyberry[bot] merged 1 commit intoOct 12, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Policy evaluation and upstream parsers must not select different `Host` field lines from the same request. ## What changed Return `400 Bad Request` for multiple `Host` headers, including identical values, before policy evaluation, upstream forwarding, or Unix socket routing. Apply the check to both plain HTTP requests and `CONNECT` requests. ## Testing Add regression tests covering identical and conflicting headers in origin-form, absolute-form, and `CONNECT` requests, verifying rejection without an upstream connection. Also cover single-header forwarding and rejection before Unix socket routing. GitOrigin-RevId: 8ec95171e120f784629d3121b9a1bedbaf88e7cd
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/8ec95171e120f784629d3121b9a1bedbaf88e7cd
branch
from
October 12, 2026 23:46
32dad27 to
12cca49
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/8ec95171e120f784629d3121b9a1bedbaf88e7cd
branch
October 12, 2026 23:46
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject duplicate Host headers in the network proxy
Why
Policy evaluation and upstream parsers must not select different
Hostfield lines from the same request.What changed
Return
400 Bad Requestfor multipleHostheaders, including identical values, before policy evaluation, upstream forwarding, or Unix socket routing. Apply the check to both plain HTTP requests andCONNECTrequests.Testing
Add regression tests covering identical and conflicting headers in origin-form, absolute-form, and
CONNECTrequests, verifying rejection without an upstream connection. Also cover single-header forwarding and rejection before Unix socket routing.