Skip to content

Deduplicate TUI modifier handling and terminal color caching - #53556

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/35f8d77ade972b791c6beac0678d2fe2be3aa763
Oct 13, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/35f8d77ade972b791c6beac0678d2fe2be3aa763

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Deduplicate TUI modifier handling and terminal color caching

What changed

  • Reuse custom_terminal::ModifierDiff when writing history spans.
  • Share the terminal default-color probe and cache implementation between Unix and Windows.

Both changes remove duplicate implementations while preserving existing behavior.

## What changed

- Reuse `custom_terminal::ModifierDiff` when writing history spans.
- Share the terminal default-color probe and cache implementation between Unix and Windows.

Both changes remove duplicate implementations while preserving existing behavior.

GitOrigin-RevId: 35f8d77ade972b791c6beac0678d2fe2be3aa763
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/35f8d77ade972b791c6beac0678d2fe2be3aa763 branch from 8377d5e to f82e365 Compare October 13, 2026 04:42
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-13T04:42:15.386397Z 8377d5e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit f82e365 into main Oct 13, 2026
11 of 18 checks passed
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/35f8d77ade972b791c6beac0678d2fe2be3aa763 branch October 13, 2026 04:42
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 13, 2026
@Rage819
Rage819 deployed to issue-triage October 13, 2026 04:42 — with Image GitHub Actions Active
@Rage819
Rage819 deployed to issue-triage October 13, 2026 04:42 — with Image GitHub Actions Active
@Rage819
Rage819 deployed to issue-triage October 13, 2026 04:42 — with Image GitHub Actions Active
@omhafez
omhafez deployed to issue-triage October 13, 2026 04:43 — with Image GitHub Actions Active
@omhafez
omhafez deployed to issue-triage October 13, 2026 04:43 — with Image GitHub Actions Active
@omhafez
omhafez deployed to issue-triage October 13, 2026 04:43 — with Image GitHub Actions Active
@kriouerlia
kriouerlia deployed to issue-triage October 13, 2026 04:44 — with Image GitHub Actions Active
@kriouerlia
kriouerlia deployed to issue-triage October 13, 2026 04:44 — with Image GitHub Actions Active
@kriouerlia
kriouerlia deployed to issue-triage October 13, 2026 04:44 — with Image GitHub Actions Active
@chenyenshou
chenyenshou deployed to issue-triage October 13, 2026 04:44 — with Image GitHub Actions Active
@chenyenshou
chenyenshou deployed to issue-triage October 13, 2026 04:44 — with Image GitHub Actions Active
@chenyenshou
chenyenshou deployed to issue-triage October 13, 2026 04:44 — with Image GitHub Actions Active
@omhafez
omhafez deployed to issue-triage October 13, 2026 04:44 — with Image GitHub Actions Active
@chenyenshou
chenyenshou deployed to issue-triage October 13, 2026 04:45 — with Image GitHub Actions Active
@scefali
scefali deployed to issue-triage October 13, 2026 04:56 — with Image GitHub Actions Active
@scefali
scefali deployed to issue-triage October 13, 2026 04:56 — with Image GitHub Actions Active
@scefali
scefali deployed to issue-triage October 13, 2026 04:56 — with Image GitHub Actions Active
@exaltedapps
exaltedapps deployed to issue-triage October 13, 2026 05:36 — with Image GitHub Actions Active
@exaltedapps
exaltedapps deployed to issue-triage October 13, 2026 05:36 — with Image GitHub Actions Active
@exaltedapps
exaltedapps deployed to issue-triage October 13, 2026 05:36 — with Image GitHub Actions Active
@Liiiszt
Liiiszt deployed to issue-triage October 13, 2026 06:07 — with Image GitHub Actions Active
@Liiiszt
Liiiszt deployed to issue-triage October 13, 2026 06:07 — with Image GitHub Actions Active
@Liiiszt
Liiiszt deployed to issue-triage October 13, 2026 06:07 — with Image GitHub Actions Active
@Liiiszt
Liiiszt deployed to issue-triage October 13, 2026 06:07 — with Image GitHub Actions Active
@Liiiszt
Liiiszt deployed to issue-triage October 13, 2026 06:07 — with Image GitHub Actions Active
@Liiiszt
Liiiszt deployed to issue-triage October 13, 2026 06:07 — with Image GitHub Actions Active
@kjhan0606
kjhan0606 deployed to issue-triage October 13, 2026 06:08 — with Image GitHub Actions Active
@kjhan0606
kjhan0606 deployed to issue-triage October 13, 2026 06:08 — with Image GitHub Actions Active
@kjhan0606
kjhan0606 deployed to issue-triage October 13, 2026 06:08 — with Image GitHub Actions Active
@rajesh58627
rajesh58627 deployed to issue-triage October 13, 2026 06:22 — with Image GitHub Actions Active
@rajesh58627
rajesh58627 deployed to issue-triage October 13, 2026 06:22 — with Image GitHub Actions Active
@rajesh58627
rajesh58627 deployed to issue-triage October 13, 2026 06:22 — with Image GitHub Actions Active
@sushiHex
sushiHex deployed to issue-triage October 13, 2026 06:23 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — f82e3659 Deployed Oct 13, 2026 by geko85 via Identify potential duplicates (open issues fallback) #54997
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.