Repository navigation
Add async compaction feature configuration - #53595
Merged
copyberry[bot] merged 1 commit intoOct 13, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## What changed Register the disabled-by-default `async_compaction` feature and accept either a boolean or a `[features.async_compaction]` table. Add `model_async_compact_threshold_percent` with a default of 65 and a valid range of 1–100, validated even when the feature is disabled. Setting a threshold alone does not enable the feature. Expose the threshold in the runtime configuration and update the JSON schema for both configuration forms. ## Testing Add configuration loader tests covering boolean and table forms, default and custom thresholds, explicit enablement, and rejection of out-of-range values. GitOrigin-RevId: cf33de76878e7044bc8cf5d146375a07ea9eb078
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/cf33de76878e7044bc8cf5d146375a07ea9eb078
branch
from
October 13, 2026 07:32
c077dee to
669449b
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/cf33de76878e7044bc8cf5d146375a07ea9eb078
branch
October 13, 2026 07:32
mohammedalthurayaaudit-netizen
deployed
to
issue-triage
October 13, 2026 08:13 — with
GitHub Actions
Active
mohammedalthurayaaudit-netizen
deployed
to
issue-triage
October 13, 2026 08:13 — with
GitHub Actions
Active
mohammedalthurayaaudit-netizen
deployed
to
issue-triage
October 13, 2026 08:13 — with
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add async compaction feature configuration
What changed
Register the disabled-by-default
async_compactionfeature and accept either a boolean or a[features.async_compaction]table. Addmodel_async_compact_threshold_percentwith a default of 65 and a valid range of 1–100, validated even when the feature is disabled. Setting a threshold alone does not enable the feature.Expose the threshold in the runtime configuration and update the JSON schema for both configuration forms.
Testing
Add configuration loader tests covering boolean and table forms, default and custom thresholds, explicit enablement, and rejection of out-of-range values.