Skip to content

Add async compaction feature configuration - #53595

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/cf33de76878e7044bc8cf5d146375a07ea9eb078
Oct 13, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/cf33de76878e7044bc8cf5d146375a07ea9eb078

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Add async compaction feature configuration

What changed

Register the disabled-by-default async_compaction feature and accept either a boolean or a [features.async_compaction] table. Add model_async_compact_threshold_percent with a default of 65 and a valid range of 1–100, validated even when the feature is disabled. Setting a threshold alone does not enable the feature.

Expose the threshold in the runtime configuration and update the JSON schema for both configuration forms.

Testing

Add configuration loader tests covering boolean and table forms, default and custom thresholds, explicit enablement, and rejection of out-of-range values.

## What changed

Register the disabled-by-default `async_compaction` feature and accept either a boolean or a `[features.async_compaction]` table. Add `model_async_compact_threshold_percent` with a default of 65 and a valid range of 1–100, validated even when the feature is disabled. Setting a threshold alone does not enable the feature.

Expose the threshold in the runtime configuration and update the JSON schema for both configuration forms.

## Testing

Add configuration loader tests covering boolean and table forms, default and custom thresholds, explicit enablement, and rejection of out-of-range values.

GitOrigin-RevId: cf33de76878e7044bc8cf5d146375a07ea9eb078
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/cf33de76878e7044bc8cf5d146375a07ea9eb078 branch from c077dee to 669449b Compare October 13, 2026 07:32
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-13T07:32:37.453926Z c077dee PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit 669449b into main Oct 13, 2026
14 of 23 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/cf33de76878e7044bc8cf5d146375a07ea9eb078 branch October 13, 2026 07:32
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 13, 2026
@futureyang
futureyang deployed to issue-triage October 13, 2026 07:35 — with Image GitHub Actions Active
@futureyang
futureyang deployed to issue-triage October 13, 2026 07:35 — with Image GitHub Actions Active
@futureyang
futureyang deployed to issue-triage October 13, 2026 07:35 — with Image GitHub Actions Active
@bestolkovy
bestolkovy deployed to issue-triage October 13, 2026 07:45 — with Image GitHub Actions Active
@bestolkovy
bestolkovy deployed to issue-triage October 13, 2026 07:45 — with Image GitHub Actions Active
@bestolkovy
bestolkovy deployed to issue-triage October 13, 2026 07:45 — with Image GitHub Actions Active
@yf-river
yf-river deployed to issue-triage October 13, 2026 07:48 — with Image GitHub Actions Active
@yf-river
yf-river deployed to issue-triage October 13, 2026 07:48 — with Image GitHub Actions Active
@yf-river
yf-river deployed to issue-triage October 13, 2026 07:48 — with Image GitHub Actions Active
@henrywhuang
henrywhuang deployed to issue-triage October 13, 2026 07:56 — with Image GitHub Actions Active
@henrywhuang
henrywhuang deployed to issue-triage October 13, 2026 07:56 — with Image GitHub Actions Active
@henrywhuang
henrywhuang deployed to issue-triage October 13, 2026 07:56 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 669449b0 Deployed Oct 13, 2026 by mohammedalthurayaaudit-netizen via Translate non-English issue #19774
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.