Repository navigation
Record truncation metrics for accepted Guardian review inputs - #53628
Merged
copyberry[bot] merged 1 commit intoOct 13, 2026
Conversation
## What changed Emit `codex.guardian.review.truncation` counts and `codex.guardian.review.truncation.bytes` histograms after successful input finalization. Aggregate observations across reduction stages by component and disposition (`truncated` or `omitted`), recording original, retained, and omitted byte totals. Exclude feasibility checks and failed retries from loss telemetry. Keep blocking command-hook cancellation fixtures in the local environment and use double quotes for the Python command. ## Testing Add metric-export tests covering aggregation across multiple reductions, separate truncation and omission totals, no loss metrics for rejected inputs, and no duplicate reporting on repeated finalization. GitOrigin-RevId: 69182fc7afe230be69dd2469caedb5ae4494947b
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/69182fc7afe230be69dd2469caedb5ae4494947b
branch
from
October 13, 2026 10:21
3fbb44c to
f529722
Compare
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/69182fc7afe230be69dd2469caedb5ae4494947b
branch
October 13, 2026 10:21
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record truncation metrics for accepted Guardian review inputs
What changed
Emit
codex.guardian.review.truncationcounts andcodex.guardian.review.truncation.byteshistograms after successful input finalization. Aggregate observations across reduction stages by component and disposition (truncatedoromitted), recording original, retained, and omitted byte totals. Exclude feasibility checks and failed retries from loss telemetry.Keep blocking command-hook cancellation fixtures in the local environment and use double quotes for the Python command.
Testing
Add metric-export tests covering aggregation across multiple reductions, separate truncation and omission totals, no loss metrics for rejected inputs, and no duplicate reporting on repeated finalization.