Repository navigation
Materialize the thread before testing a discovered daemon restart - #53631
Merged
copyberry[bot] merged 1 commit intoOct 13, 2026
Conversation
…3631) Empty drafts need not survive a daemon restart. Update the `discovered` scenario in `codex-rs/cli/tests/daemon_startup.rs` to rename the thread before restarting the daemon and include `thread-name` in the status line. Wait for the confirmed footer name before issuing `/daemon` so the test proceeds only after the thread is materialized. GitOrigin-RevId: a91508582826fa1bd0cc7b89d9a1af7e8b4e1999
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/a91508582826fa1bd0cc7b89d9a1af7e8b4e1999
branch
from
October 13, 2026 10:32
9c7d128 to
86966c3
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/a91508582826fa1bd0cc7b89d9a1af7e8b4e1999
branch
October 13, 2026 10:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Materialize the thread before testing a discovered daemon restart
Empty drafts need not survive a daemon restart. Update the
discoveredscenario in
codex-rs/cli/tests/daemon_startup.rsto rename the thread beforerestarting the daemon and include
thread-namein the status line. Wait forthe confirmed footer name before issuing
/daemonso the test proceeds onlyafter the thread is materialized.