Repository navigation
Stabilize write ordering in the shared message board scenario - #53632
Merged
copyberry[bot] merged 1 commit intoOct 13, 2026
Conversation
## Why Non-parallel tool calls can acquire their lock in either order, making the shared board scenario's `last_message_id` snapshot nondeterministic. ## What changed Send each `collaboration.post` call in a separate mocked response to order the writes before snapshotting. Update the `board_connections` snapshot and expected request count from 15 to 17 to reflect the additional responses. GitOrigin-RevId: a290a01f5071a2081d4d0b1531b1b31bfbb8a6e6
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/a290a01f5071a2081d4d0b1531b1b31bfbb8a6e6
branch
from
October 13, 2026 10:42
46cf850 to
6042ec3
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/a290a01f5071a2081d4d0b1531b1b31bfbb8a6e6
branch
October 13, 2026 10:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stabilize write ordering in the shared message board scenario
Why
Non-parallel tool calls can acquire their lock in either order, making the shared board scenario's
last_message_idsnapshot nondeterministic.What changed
Send each
collaboration.postcall in a separate mocked response to order the writes before snapshotting. Update theboard_connectionssnapshot and expected request count from 15 to 17 to reflect the additional responses.