Skip to content

Add an environment API key fallback for Guardian Decisions - #53633

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/fbb772dcb9287d9e1be1b34292ad9bdffeb3d6b3
Oct 13, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/fbb772dcb9287d9e1be1b34292ad9bdffeb3d6b3

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Add an environment API key fallback for Guardian Decisions

What changed

Allow Guardian Decisions to use OPENAI_API_KEY when the default openai provider has no custom base URL and neither CODEX_GUARDIAN_DECISIONS_API_KEY nor a cached API key is available. Preserve cached API key precedence over the environment fallback.

Report missing credentials as credentials_unavailable instead of provider_error in Decisions failure metrics.

Testing

Add tests for cached API key precedence and the environment fallback with ChatGPT authentication. Run each test in a child process to isolate environment changes.

## What changed

Allow Guardian Decisions to use `OPENAI_API_KEY` when the default `openai` provider has no custom base URL and neither `CODEX_GUARDIAN_DECISIONS_API_KEY` nor a cached API key is available. Preserve cached API key precedence over the environment fallback.

Report missing credentials as `credentials_unavailable` instead of `provider_error` in Decisions failure metrics.

## Testing

Add tests for cached API key precedence and the environment fallback with ChatGPT authentication. Run each test in a child process to isolate environment changes.

GitOrigin-RevId: fbb772dcb9287d9e1be1b34292ad9bdffeb3d6b3
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/fbb772dcb9287d9e1be1b34292ad9bdffeb3d6b3 branch from d1c8384 to 90f00bd Compare October 13, 2026 10:43
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-13T10:43:25.860690Z d1c8384 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit 90f00bd into main Oct 13, 2026
1 check failed
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/fbb772dcb9287d9e1be1b34292ad9bdffeb3d6b3 branch October 13, 2026 10:43
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 13, 2026
@lianzeng
lianzeng deployed to issue-triage October 13, 2026 10:46 — with Image GitHub Actions Active
@lianzeng
lianzeng deployed to issue-triage October 13, 2026 10:46 — with Image GitHub Actions Active
@lianzeng
lianzeng deployed to issue-triage October 13, 2026 10:46 — with Image GitHub Actions Active
@wc1016
wc1016 deployed to issue-triage October 13, 2026 10:47 — with Image GitHub Actions Active
@wc1016
wc1016 deployed to issue-triage October 13, 2026 10:47 — with Image GitHub Actions Active
@wc1016
wc1016 deployed to issue-triage October 13, 2026 10:47 — with Image GitHub Actions Active
@lianzeng
lianzeng deployed to issue-triage October 13, 2026 10:48 — with Image GitHub Actions Active
@nobu731
nobu731 deployed to issue-triage October 13, 2026 10:55 — with Image GitHub Actions Active
@nobu731
nobu731 deployed to issue-triage October 13, 2026 10:55 — with Image GitHub Actions Active
@nobu731
nobu731 deployed to issue-triage October 13, 2026 10:55 — with Image GitHub Actions Active
@moniter0415
moniter0415 deployed to issue-triage October 13, 2026 10:56 — with Image GitHub Actions Active
@moniter0415
moniter0415 deployed to issue-triage October 13, 2026 10:56 — with Image GitHub Actions Active
@moniter0415
moniter0415 deployed to issue-triage October 13, 2026 10:56 — with Image GitHub Actions Active
@KonstanzDPS
KonstanzDPS deployed to issue-triage October 13, 2026 10:56 — with Image GitHub Actions Active
@KonstanzDPS
KonstanzDPS deployed to issue-triage October 13, 2026 10:56 — with Image GitHub Actions Active
@KonstanzDPS
KonstanzDPS deployed to issue-triage October 13, 2026 10:56 — with Image GitHub Actions Active
@moniter0415
moniter0415 deployed to issue-triage October 13, 2026 10:57 — with Image GitHub Actions Active
@jingyihu818
jingyihu818 deployed to issue-triage October 13, 2026 11:00 — with Image GitHub Actions Active
@jingyihu818
jingyihu818 deployed to issue-triage October 13, 2026 11:00 — with Image GitHub Actions Active
@jingyihu818
jingyihu818 deployed to issue-triage October 13, 2026 11:00 — with Image GitHub Actions Active
@LarreAI
LarreAI deployed to issue-triage October 13, 2026 11:28 — with Image GitHub Actions Active
@LarreAI
LarreAI deployed to issue-triage October 13, 2026 11:28 — with Image GitHub Actions Active
@okumurays
okumurays deployed to issue-triage October 13, 2026 12:12 — with Image GitHub Actions Active
@okumurays
okumurays deployed to issue-triage October 13, 2026 12:12 — with Image GitHub Actions Active
@okumurays
okumurays deployed to issue-triage October 13, 2026 12:12 — with Image GitHub Actions Active
@okumurays
okumurays deployed to issue-triage October 13, 2026 12:13 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 90f00bd8 Deployed Oct 13, 2026 by 2510495678dd-cpu via Generate label suggestions #55075
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.