Skip to content

Constrain API-key model access programs to server support - #53689

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/c80de30a0063b84949098d137715d8678bd70587
Oct 13, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/c80de30a0063b84949098d137715d8678bd70587

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Constrain API-key model access programs to server support

Why

Servers can advertise cyber access programs without accepting them for API-key accounts. The TUI must account for server support before exposing those programs.

What changed

  • Check features.api_key_cyber_access_programs at startup and when loading models for API-key accounts, clearing available_access_programs when forwarding is unavailable.
  • Use thread-scoped feature settings after thread creation and honor feature requirements and CLI overrides at startup.
  • Refresh account-scoped models when switching to or from API-key authentication or changing API-key thread context, clearing cached access programs while the refresh is pending.

Testing

Extend session tests to cover enabled and disabled server settings, CLI overrides, and catalog filtering before and after thread creation. Update account-change tests to handle the model refresh.

## Why

Servers can advertise cyber access programs without accepting them for API-key accounts. The TUI must account for server support before exposing those programs.

## What changed

- Check `features.api_key_cyber_access_programs` at startup and when loading models for API-key accounts, clearing `available_access_programs` when forwarding is unavailable.
- Use thread-scoped feature settings after thread creation and honor feature requirements and CLI overrides at startup.
- Refresh account-scoped models when switching to or from API-key authentication or changing API-key thread context, clearing cached access programs while the refresh is pending.

## Testing

Extend session tests to cover enabled and disabled server settings, CLI overrides, and catalog filtering before and after thread creation. Update account-change tests to handle the model refresh.

GitOrigin-RevId: c80de30a0063b84949098d137715d8678bd70587
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/c80de30a0063b84949098d137715d8678bd70587 branch from da90d71 to c03bbff Compare October 13, 2026 15:03
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-13T15:03:47.018776Z da90d71 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot merged commit c03bbff into main Oct 13, 2026
1 check failed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/c80de30a0063b84949098d137715d8678bd70587 branch October 13, 2026 15:03
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 13, 2026
@fmoraruiz
fmoraruiz deployed to issue-triage October 13, 2026 15:04 — with Image GitHub Actions Active
@fmoraruiz
fmoraruiz deployed to issue-triage October 13, 2026 15:04 — with Image GitHub Actions Active
@fmoraruiz
fmoraruiz deployed to issue-triage October 13, 2026 15:04 — with Image GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — c03bbff4 Deployed Oct 13, 2026 by fmoraruiz via Identify potential duplicates (all issues) #55113
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants