Skip to content

Add keyboard selection support to the transcript view - #53693

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/e5bc380ea0eb6e2c6157ba73ac063d548a7de145
Oct 13, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/e5bc380ea0eb6e2c6157ba73ac063d548a7de145

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Add keyboard selection support to the transcript view

What changed

Add transcript select-mode state with an underlined cursor, grapheme-aware movement via arrow keys or h/j/k/l, and vertical movement that preserves the preferred display column. Support marking with v, Space, or Shift-arrow keys and copying through the existing selection machinery.

Keep the displayed transcript snapshot and reading position paused during selection and after exiting the mode. Add entry and exit methods; this change does not yet bind mode entry to a user-facing key.

Testing

Add unit tests for initial cursor placement, movement across empty lines and entry boundaries, wrapped text, preferred-column preservation, and Enter behavior with and without a marked range.

## What changed

Add transcript select-mode state with an underlined cursor, grapheme-aware movement via arrow keys or `h`/`j`/`k`/`l`, and vertical movement that preserves the preferred display column. Support marking with `v`, Space, or Shift-arrow keys and copying through the existing selection machinery.

Keep the displayed transcript snapshot and reading position paused during selection and after exiting the mode. Add entry and exit methods; this change does not yet bind mode entry to a user-facing key.

## Testing

Add unit tests for initial cursor placement, movement across empty lines and entry boundaries, wrapped text, preferred-column preservation, and Enter behavior with and without a marked range.

GitOrigin-RevId: e5bc380ea0eb6e2c6157ba73ac063d548a7de145
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/e5bc380ea0eb6e2c6157ba73ac063d548a7de145 branch from f6ca90e to 3143440 Compare October 13, 2026 15:11
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-13T15:11:24.313780Z f6ca90e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@copyberry
copyberry Bot merged commit 3143440 into main Oct 13, 2026
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/e5bc380ea0eb6e2c6157ba73ac063d548a7de145 branch October 13, 2026 15:11
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 13, 2026
@zuojipeng
zuojipeng deployed to issue-triage October 13, 2026 15:16 — with Image GitHub Actions Active
@zuojipeng
zuojipeng deployed to issue-triage October 13, 2026 15:16 — with Image GitHub Actions Active
@zuojipeng
zuojipeng deployed to issue-triage October 13, 2026 15:16 — with Image GitHub Actions Active
@zuojipeng
zuojipeng deployed to issue-triage October 13, 2026 15:17 — with Image GitHub Actions Active
@KaizukiMada
KaizukiMada deployed to issue-triage October 13, 2026 15:23 — with Image GitHub Actions Active
@KaizukiMada
KaizukiMada deployed to issue-triage October 13, 2026 15:23 — with Image GitHub Actions Active
@KaizukiMada
KaizukiMada deployed to issue-triage October 13, 2026 15:23 — with Image GitHub Actions Active

This branch had an error being deployed

1 failed deployment
issue-triage — 31434401 Deployed Oct 13, 2026 by yoga1948yoga-png via Identify potential duplicates (all issues) #55121
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants