Repository navigation
feat: Make exact table search result auto show up - #1106
Merged
Merged
Conversation
czgu
marked this pull request as ready for review
December 20, 2022 01:50
jczhong84
reviewed
Dec 20, 2022
Comment on lines
+26
to
+30
| return dataTables.find( | ||
| (table) => | ||
| table.name === searchStringTable && | ||
| table.schema === searchStringSchema | ||
| )?.id; |
Collaborator
There was a problem hiding this comment.
would it be simpler to find by joining the schema and name?
dataTables.find(
(table) =>
`${table.schema}.${table.name}` === searchString.trim()
)
Collaborator
Author
There was a problem hiding this comment.
good point, i also wanted to include filters as well. Updated the PR
jczhong84
approved these changes
Dec 20, 2022
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Feb 28, 2023
* feat: Make exact table search result auto show up * do not let user double select * Mix exact match and user selected table together * also incorporate filters into logic
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* feat: Make exact table search result auto show up * do not let user double select * Mix exact match and user selected table together * also incorporate filters into logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you enter the table name exactly, the table would auto show up in the bottom bar
