Repository navigation
Conversation
czgu
approved these changes
Jan 31, 2023
czgu
left a comment
czgu
left a comment
Collaborator
There was a problem hiding this comment.
the issue is we are redirecting to root when deleting doc instead redirecting to env:
<Route path="/:env/datadoc/" exact={true}>
<Redirect to="/" />
</Route>
just leaving it as a note here. No change needed.
Thanks for fixing this bug!
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Apr 11, 2023
Co-authored-by: Lily Li <lli6@expediagroup.com>
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
Co-authored-by: Lily Li <lli6@expediagroup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where deleting a DataDoc in a non-default environment causes the UI to jump to the default environment instead of remaining in the current environment. The issue seems to be related to QB reloading after attempting to navigate to '{currentEnv.name}/datadoc' after deleting a datadoc. The change included in this PR avoids the reload while also refreshing the page to be able to see that the datadoc was deleted.