Skip to content

ui: Update searchbar css - #1142

Merged
czgu merged 3 commits into
pinterest:masterfrom
czgu:searchfix
Feb 2, 2023
Merged

ui: Update searchbar css#1142
czgu merged 3 commits into
pinterest:masterfrom
czgu:searchfix

Conversation

@czgu

@czgu czgu commented Feb 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Changed from clear button to 'x'
    Before:

image

After:

image

  • this makes the component fit better with small filter bars:

image

  • removed unnecessary css
  • fix: Added white background for searchbar when in engine picker
  • only show column filter if there are more than 5 columns

@czgu
czgu marked this pull request as ready for review February 2, 2023 17:56
@czgu
czgu merged commit bae5c53 into pinterest:master Feb 2, 2023
@czgu
czgu deleted the searchfix branch February 2, 2023 19:11
rohan-sh1 pushed a commit to CAI-TECHNOLOGIES/cai-ext-db-explorer that referenced this pull request Apr 11, 2023
@czgu @rohan-sh1
ui: Update searchbar css (pinterest#1142)
3751ffc 
* Update searchbar css

* self review

* added constant to control when to show search bar
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
@czgu @aidenprice
ui: Update searchbar css (pinterest#1142)
c8c9f08 
* Update searchbar css

* self review

* added constant to control when to show search bar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jczhong84 jczhong84 jczhong84 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@czgu @jczhong84