Skip to content

Use gevent for celery worker, update timeout to GeventTimeout - #1345

Merged
czgu merged 4 commits into
pinterest:masterfrom
czgu:hotfix
Oct 12, 2023
Merged

czgu merged 4 commits into
pinterest:masterfrom
czgu:hotfix

Conversation

@czgu

@czgu czgu commented Oct 11, 2023 •

Copy link
Copy Markdown
Collaborator

Resolves #1337

  • The Timeout function previously would crash celery worker due to the way exception was raised
  • Instead, we now use gevent timeout paired with gevent worker
  • The old timeout is kept as is incase it breaks any downstream code

meowcodes
meowcodes previously approved these changes Oct 11, 2023
@czgu
czgu merged commit 7480a64 into pinterest:master Oct 12, 2023
@czgu
czgu deleted the hotfix branch October 12, 2023 03:25
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
…est#1345)

* hotfix for worker starting up

* Use gevent for celery worker, update timeout to GeventTimeout

* Use gevent for celery worker, update timeout to GeventTimeout

* Default back to multiprocess worker, but with Timeout dynamic for gevent and non-gevent cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timed out waiting for UP message from ForkProcess

3 participants