Skip to content

fix: Add scroll bar to Query Engine Status popover - #1353

Merged
czgu merged 1 commit into
pinterest:masterfrom
baumandm:external/query-engine-status-scroll
Nov 29, 2023
Merged

czgu merged 1 commit into
pinterest:masterfrom
baumandm:external/query-engine-status-scroll

Conversation

@baumandm

Copy link
Copy Markdown
Contributor

Environments with many Query Engines break the Query Engine status popover, so this PR adds a max-height and a scrollbar to keep everything on the screen.

Before: 😿
Screen Shot 2023-10-23 at 09 54 25-fullpage

After: 😸
Screen Shot 2023-10-23 at 09 54 42-fullpage

@czgu
czgu merged commit f8d8dd4 into pinterest:master Nov 29, 2023
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
@baumandm
baumandm deleted the external/query-engine-status-scroll branch January 10, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants