Repository navigation
fix: s3 table upload location - #1376
Merged
Merged
Conversation
czgu
reviewed
Nov 28, 2023
czgu
reviewed
Nov 29, 2023
|
|
||
| Made below changes for `S3BaseExporter` (csv table uploader feature): | ||
|
|
||
| - Both `s3_path` and `use_schema_location` are optional now |
Collaborator
There was a problem hiding this comment.
you need to mention if use_schema_location=True before 3.29.0, it would create managed table, now it creates external
czgu
previously approved these changes
Nov 29, 2023
czgu
approved these changes
Nov 29, 2023
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* fix: s3 table upload location * fix linter * sanitize s3 path * disable redirect * fix linter * add break change & bump version * typing * remove ` * breaking change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use_schema_location=Falsefor s3 table uploader.is_external. Previouslyis_externalwill beFalsewhenuse_schema_locationis True, which supposed to be True (external table), as it is specifying location.is_external = not self._exporter_config.get("use_schema_location", False)