Skip to content

feat: upgrade langchain version - #1406

Merged
czgu merged 4 commits into
pinterest:masterfrom
jczhong84:feat/langchain
Feb 14, 2024
Merged

feat: upgrade langchain version#1406
czgu merged 4 commits into
pinterest:masterfrom
jczhong84:feat/langchain

Conversation

@jczhong84

@jczhong84 jczhong84 commented Feb 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Upgrade langchain to 0.1.6
  • Adopt the new streaming approach which support partial json streaming and remove the old streaming code
  • Also add non streaming support
  • Split sql edit from the text-to-sql prompt

kgopal492
kgopal492 reviewed Feb 5, 2024
View reviewed changes
Comment thread querybook/webapp/components/AIAssistant/QueryGenerationModal.tsx Outdated
kgopal492
kgopal492 reviewed Feb 6, 2024
View reviewed changes
Comment thread querybook/server/lib/ai_assistant/prompts/sql_title_prompt.py Outdated
kgopal492
kgopal492 previously approved these changes Feb 6, 2024
View reviewed changes
czgu
czgu reviewed Feb 13, 2024
View reviewed changes
Comment thread querybook/server/lib/ai_assistant/base_ai_assistant.py Outdated
Comment thread querybook/webapp/components/AIAssistant/AutoFixButton.tsx
baumandm
baumandm reviewed Feb 14, 2024
View reviewed changes

@baumandm baumandm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out on our side. Found one small issue with non-streaming mode, but otherwise it works great! 👍

Comment thread querybook/server/lib/ai_assistant/base_ai_assistant.py Outdated
Comment thread querybook/webapp/components/AIAssistant/QueryGenerationModal.tsx Outdated
@czgu
czgu merged commit 7208c05 into pinterest:master Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@czgu czgu czgu approved these changes
@kgopal492 kgopal492 kgopal492 left review comments
+1 more reviewer
@baumandm baumandm baumandm left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jczhong84 @baumandm @czgu @kgopal492