Skip to content

feat: Auto-load built-in notifiers if configured - #1420

Merged
jczhong84 merged 1 commit into
pinterest:masterfrom
baumandm:external/notifiers
Mar 9, 2024
Merged

jczhong84 merged 1 commit into
pinterest:masterfrom
baumandm:external/notifiers

Conversation

@baumandm

@baumandm baumandm commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

Fixes #733:

  • configures the two built-in notifiers (Slack, Email) to automatically load themselves if the corresponding configs are set
  • adds a NoopNotifier that enables itself if no other notifiers are enabled⸺it outputs notifications to the server logs
  • updated docs

@jczhong84

Copy link
Copy Markdown
Collaborator

@baumandm thanks for the PR!

@jczhong84
jczhong84 merged commit 8c6600c into pinterest:master Mar 9, 2024
@baumandm
baumandm deleted the external/notifiers branch March 11, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatically include Slack notifier if Slack Token is provided in the settings

2 participants