Skip to content

[Chart] Sort Feature - #29

Merged
czgu merged 7 commits into
masterfrom
sort
May 4, 2020
Merged

czgu merged 7 commits into
masterfrom
sort

Conversation

@meowcodes

Copy link
Copy Markdown
Contributor
  • preserve order for categorical data
  • y-axis min val is 0 unless specified

@meowcodes
meowcodes requested a review from czgu April 28, 2020 23:16
@meowcodes meowcodes changed the title [Fix] Chart Sort/Min Val [Chart] Sort Feature Apr 30, 2020

@czgu czgu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the unit test please

Comment thread datahub/webapp/lib/chart/chart-utils.ts Outdated
Comment thread datahub/webapp/lib/chart/chart-meta-processing.ts Outdated
Comment thread datahub/webapp/components/DataDocChartCell/DataDocChartComposer.tsx Outdated
Comment thread datahub/webapp/components/DataDocChartCell/DataDocChartComposer.tsx Outdated
Comment thread datahub/webapp/components/DataDocChartCell/DataDocChartComposer.tsx Outdated
Comment thread datahub/webapp/const/dataDocChart.ts Outdated
Comment thread datahub/webapp/const/dataDocChart.ts Outdated
Comment thread datahub/webapp/lib/chart/chart-data-transformation.ts Outdated
Comment thread datahub/webapp/components/DataDocChartCell/DataDocChartComposer.tsx Outdated
Comment thread datahub/webapp/lib/chart/chart-data-transformation.ts Outdated
Comment thread datahub/webapp/lib/chart/chart-data-transformation.ts Outdated
@czgu
czgu merged commit fb16f48 into master May 4, 2020
@meowcodes
meowcodes deleted the sort branch May 4, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants