Skip to content

Decentralized storybook, update to v6 - #366

Merged
czgu merged 4 commits into
masterfrom
storybookupdate
Jan 5, 2021
Merged

Decentralized storybook, update to v6#366
czgu merged 4 commits into
masterfrom
storybookupdate

Conversation

@czgu

@czgu czgu commented Jan 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Stories are now in ui/ instead of stories and is split per component file
  • updated from v5 to v6
  • added appropriate UI controls in storybook and removed additional components
  • split storybook into 5 sections: form/layout/stateless/stateful/button
    image

@czgu
czgu requested a review from meowcodes January 5, 2021 03:34
meowcodes
meowcodes reviewed Jan 5, 2021
View reviewed changes
Comment thread datahub/webapp/ui/Dropdown/Dropdown.tsx Outdated

// Click based Dropdown Control
const handleClick = React.useCallback((event) => {
console.log('wtf');

@meowcodes meowcodes Jan 5, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean haha

@czgu
czgu merged commit 36d3d03 into master Jan 5, 2021
@czgu
czgu deleted the storybookupdate branch January 5, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@meowcodes meowcodes meowcodes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@czgu @meowcodes