Skip to content

Non-existing template options now filtered out for lang in C3 - #11184

Merged
petebacondarwin merged 1 commit into
mainfrom
dominik/filter-c3
Nov 17, 2025
Merged

petebacondarwin merged 1 commit into
mainfrom
dominik/filter-c3

Conversation

@dom96

@dom96 dom96 commented Nov 5, 2025 •

Copy link
Copy Markdown
Contributor

When running create-cloudflare with the --lang=python argument, all templates are shown including ones that don't support Python. This PR filters those out.


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: feature improvement
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: c3 change

$ pnpm i
$ pnpm run test:e2e:c3

@changeset-bot

changeset-bot Bot commented Nov 5, 2025 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a720058

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Nov 5, 2025 •

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11184

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11184

miniflare

npm i https://pkg.pr.new/miniflare@11184

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11184

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11184

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11184

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11184

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11184

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11184

wrangler

npm i https://pkg.pr.new/wrangler@11184

commit: a720058

@dom96
dom96 force-pushed the dominik/filter-c3 branch 3 times, most recently from a47ce60 to 2ea9600 Compare November 5, 2025 18:36
@dom96
dom96 force-pushed the dominik/filter-c3 branch from 2ea9600 to c0c19fa Compare November 14, 2025 15:46
@dom96
dom96 marked this pull request as ready for review November 14, 2025 15:48
@dom96
dom96 requested a review from a team as a code owner November 14, 2025 15:48
@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Nov 14, 2025
@dom96
dom96 force-pushed the dominik/filter-c3 branch from c0c19fa to eed3550 Compare November 14, 2025 17:00
@petebacondarwin
petebacondarwin merged commit a8efcc8 into main Nov 17, 2025
28 checks passed
@petebacondarwin
petebacondarwin deleted the dominik/filter-c3 branch November 17, 2025 13:54
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Nov 17, 2025
@lrapoport-cf lrapoport-cf mentioned this pull request Nov 18, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants