[deploy-helpers] Containers support for Worker Preview deployments in the Build Output - #15822
Conversation
🦋 Changeset detectedLatest commit: d686cad The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
|
I'm Bonk, and I've done a quick review of your PR. Adds callback-driven Container deployment support to Build Output previews.
|
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/runtime-types
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
2c40fc0 to
e96dd77
Compare
e96dd77 to
17e6cd2
Compare
… the Build Output
17e6cd2 to
1503ca3
Compare
petebacondarwin
left a comment
There was a problem hiding this comment.
There appears to be a Bonk review worth looking into. But otherwise LGTM.
|
Bonk's review is stale. I added validation here: workers-sdk/packages/deploy-helpers/src/preview/preview.ts Lines 1360 to 1371 in 1503ca3 |
petebacondarwin
left a comment
There was a problem hiding this comment.
Codeowners bypass
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
… the Build Output (cloudflare#15822) Co-authored-by: Pete Bacon Darwin <pbacondarwin@cloudflare.com>
Fixes WC-5979.
Adds Containers support for Preview deployments in the Build Config.
A picture of a cute animal (not mandatory, but encouraged)