Skip to content

[deploy-helpers] Containers support for Worker Preview deployments in the Build Output - #15822

Merged
petebacondarwin merged 4 commits into
mainfrom
wc-5979-containers-in-deploy-helpers
Sep 24, 2026
Merged

petebacondarwin merged 4 commits into
mainfrom
wc-5979-containers-in-deploy-helpers

Conversation

@GregBrimble

@GregBrimble GregBrimble commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Fixes WC-5979.

Adds Containers support for Preview deployments in the Build Config.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: helper package change

A picture of a cute animal (not mandatory, but encouraged)


Devin Review

@changeset-bot

changeset-bot Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d686cad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@cloudflare/workers-utils Minor
@cloudflare/deploy-helpers Minor
wrangler Minor
@cloudflare/autoconfig Patch
@cloudflare/cli-shared-helpers Patch
@cloudflare/containers-shared Patch
@cloudflare/remote-bindings Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-plugin Patch
@cloudflare/workers-auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Sep 24, 2026
@workers-devprod
workers-devprod requested review from a team and tpmmorris and removed request for a team September 24, 2026 04:19
@workers-devprod

workers-devprod commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/cloudchamber
  • ✅ @cloudflare/wrangler
Show detailed file reviewers
  • packages/containers-shared/src/build.ts: [@cloudflare/cloudchamber]
  • packages/containers-shared/tests/build-and-push.test.ts: [@cloudflare/cloudchamber]

devin-ai-integration[bot]

This comment was marked as resolved.

ask-bonk[bot]

This comment was marked as resolved.

@ask-bonk

ask-bonk Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

I'm Bonk, and I've done a quick review of your PR.

Adds callback-driven Container deployment support to Build Output previews.

  1. High: Posted 1 inline suggestion.

github run

@pkg-pr-new

pkg-pr-new Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15822

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15822

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@15822

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15822

@cloudflare/containers-shared

npm i https://pkg.pr.new/@cloudflare/containers-shared@15822

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15822

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15822

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15822

miniflare

npm i https://pkg.pr.new/miniflare@15822

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15822

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15822

@cloudflare/runtime-types

npm i https://pkg.pr.new/@cloudflare/runtime-types@15822

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15822

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15822

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@15822

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15822

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15822

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15822

wrangler

npm i https://pkg.pr.new/wrangler@15822

commit: d686cad

@GregBrimble
GregBrimble force-pushed the wc-5979-containers-in-deploy-helpers branch from 2c40fc0 to e96dd77 Compare September 24, 2026 05:11
devin-ai-integration[bot]

This comment was marked as resolved.

@GregBrimble
GregBrimble force-pushed the wc-5979-containers-in-deploy-helpers branch from e96dd77 to 17e6cd2 Compare September 24, 2026 05:43
devin-ai-integration[bot]

This comment was marked as resolved.

@GregBrimble
GregBrimble marked this pull request as draft September 24, 2026 05:47
@GregBrimble
GregBrimble force-pushed the wc-5979-containers-in-deploy-helpers branch from 17e6cd2 to 1503ca3 Compare September 24, 2026 14:35
@GregBrimble
GregBrimble marked this pull request as ready for review September 24, 2026 15:01
@workers-devprod
workers-devprod requested a review from a team September 24, 2026 15:01
Comment thread packages/deploy-helpers/src/preview/preview.ts

@petebacondarwin petebacondarwin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a Bonk review worth looking into. But otherwise LGTM.

@GregBrimble

Copy link
Copy Markdown
Contributor Author

Bonk's review is stale. I added validation here:

if (
previewContainers.length > 0 &&
(callbacks?.getNormalizedContainerOptions === undefined ||
callbacks.deployPreviewContainers === undefined)
) {
throw new UserError(
"Preview uploads from Build Output with Containers require container deployment callbacks.",
{
telemetryMessage: "preview build output container callbacks missing",
}
);
}

@petebacondarwin petebacondarwin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners bypass

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Sep 24, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

Devin Review

Comment thread packages/deploy-helpers/src/preview/preview.ts
Comment thread .changeset/live-durable-object-exports.md
@petebacondarwin
petebacondarwin merged commit 8f7916c into main Sep 24, 2026
67 of 69 checks passed
@petebacondarwin
petebacondarwin deleted the wc-5979-containers-in-deploy-helpers branch September 24, 2026 21:00
Wichtowski pushed a commit to Wichtowski/workers-sdk that referenced this pull request Sep 24, 2026
… the Build Output (cloudflare#15822)

Co-authored-by: Pete Bacon Darwin <pbacondarwin@cloudflare.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants