command/exec: Fill ConsoleSize#3627
Merged
thaJeztah merged 1 commit intodocker:masterfrom Jun 27, 2022
Merged
Conversation
This makes the exec'd process console dimensions immediately match the users terminal. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #3627 +/- ##
==========================================
- Coverage 59.01% 59.00% -0.02%
==========================================
Files 289 289
Lines 24623 24634 +11
==========================================
+ Hits 14532 14536 +4
- Misses 9218 9224 +6
- Partials 873 874 +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
Relates to:
This makes the exec'd process started with console dimensions matching the users terminal.
- How I did it
Set the exec config ConsoleSize to cli stdout tty size
- How to verify it
- Description for the changelog
docker exec -tnow sets the console size for the exec'd process immediately when it's created- A picture of a cute animal (not mandatory but encouraged)