Do not truncate ID on docker service ps --quiet#579
Merged
dnephin merged 1 commit intodocker:masterfrom Oct 2, 2017
Merged
Conversation
Running `docker service ps --quiet` should print the full, non-truncated ID, even if the `--no-trunc` option is not set. This patch disables truncation if the `--quiet` flag is set. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
==========================================
+ Coverage 49.38% 49.41% +0.03%
==========================================
Files 208 208
Lines 17178 17181 +3
==========================================
+ Hits 8483 8490 +7
+ Misses 8262 8259 -3
+ Partials 433 432 -1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #543
Running
docker service ps --quietshould print thefull, non-truncated ID, even if the
--no-truncoptionis not set.
This patch disables truncation if the
--quietflagis set.
- What I did
Updated the code to override
options.noTruncifoptions.quietis set- How to verify it
Run
docker service ps <servicename>and verify that the full, non-truncated ID is printed.- Description for the changelog
ping @stevvooe PTAL