Correct references to --publish long syntax in docs#746
Merged
thaJeztah merged 1 commit intodocker:masterfrom Dec 13, 2017
lachlancooper:master
Merged
Correct references to --publish long syntax in docs#746thaJeztah merged 1 commit intodocker:masterfrom lachlancooper:master
thaJeztah merged 1 commit intodocker:masterfrom
lachlancooper:master
Conversation
lachlancooper
requested review from
mdlinville,
thaJeztah and
vdemeester
as code owners
|
Please sign your commits following these rules: $ git clone -b "master" git@github.com:lachlancooper/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
This is the same issue as described at docker/docs#5370 Signed-off-by: Lachlan Cooper <lachlancooper@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
=======================================
Coverage 53.45% 53.45%
=======================================
Files 218 218
Lines 14613 14613
=======================================
Hits 7811 7811
Misses 6321 6321
Partials 481 481 |
mdlinville
approved these changes
Dec 12, 2017
Contributor
mdlinville
left a comment
mdlinville
left a comment
There was a problem hiding this comment.
LGTM after you follow the instructions to sign the commit. Sorry, you can't just edit in the Github editor for this repo. Thanks for this!
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
Correct references to --publish long syntax in docs Upstream-commit: 29ae8cf Component: cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the argument names in the long syntax for the
--publish,--publish-add, and--publish-rmflags. The correct arguments arepublishedandtarget, nottargetandport.The issue is described in more detail at docker/docs#5370