handle "stop" event#9019
Merged
Merged
Conversation
ulyssessouza
reviewed
Dec 8, 2021
Contributor
|
@ndeloof gofmt |
ndeloof
force-pushed
the
8523
branch
3 times, most recently
from
December 9, 2021 08:51
7d39396 to
91509e3
Compare
ulyssessouza
self-requested a review
December 9, 2021 09:47
ulyssessouza
suggested changes
Dec 9, 2021
ulyssessouza
left a comment
ulyssessouza
left a comment
Contributor
There was a problem hiding this comment.
Just the spammer line
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
enabled auto-merge (rebase)
December 9, 2021 12:11
ulyssessouza
approved these changes
Dec 9, 2021
ulyssessouza
left a comment
ulyssessouza
left a comment
Contributor
There was a problem hiding this comment.
LGTM. But I just noticed we have no tests for this function :(
FYI, I posted a non-interactive (no manual step) reproducer for this bug here: #9003 (comment) I'm not familiar with your CI setup but I expect it should be easy enough to add that |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
This is an alternative to #9018
catching the
stopevent, we can stop watching a container and consider it "done"this include moving
convertto a non-main package as this prevent debugger to start in GolandRelated issue
fixes: #8523
(not mandatory) A picture of a cute animal, if possible in relation with what you did
(he won't run anymore)