Adds a few more names to the name generator.#37157

debayande · 2018-05-26T07:24:08Z

- What I did
Added a few more names to the name generator

- How I did it
I added the names to pkg/namesgenerator/names-generator.go

- How to verify it
Please check pkg/namesgenerator/names-generator.go

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

AkihiroSuda · 2018-05-26T08:27:15Z

Her family name is Tu

Oops! Will fix right away.

codecov · 2018-05-26T13:56:20Z

Codecov Report

❗ No coverage uploaded for pull request base (master@b0e6eed). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37157   +/-   ##
=========================================
  Coverage          ?   34.95%           
=========================================
  Files             ?      610           
  Lines             ?    44869           
  Branches          ?        0           
=========================================
  Hits              ?    15682           
  Misses            ?    27072           
  Partials          ?     2115

AkihiroSuda · 2018-06-28T04:13:19Z

Please rebase?

debayande · 2018-06-28T12:24:03Z

Done!

AkihiroSuda · 2018-06-29T15:32:44Z

@thaJeztah PTAL?

thaJeztah · 2018-06-30T18:21:24Z

Looks like it's a double lastname ("Kamerlingh Onnes") - that may be a big lengthy though, so not sure what's best

Replaced by Ralph C. Merkle.

thaJeztah · 2018-06-30T18:22:26Z

Lastname is "berners-lee" IIUC; could be tricky with the dash (don't think we have a name containing a dash so far)

Actually, we do: cf. al-Battānī, Joliot-Curie, Payne-Gaposchkin, Levi-Montalcini, Barré-Sinoussi, Nüsslein-Volhard.

In each of these cases, the committer has chosen to go either with the first or the second of the two dashed surnames, or with a concatenation of the two. I've chosen to go with the first.

Hm, looks like we're not really consistent there, or the committer may have misinterpreted double names as maiden names. For al-Battānī, I see that al- is more of a "prefix" (so possibly that's commonly excluded / not part of the last name). For Joliot-Curie, Payne-Gaposchkin, Barré-Sinoussi, and Nüsslein-Volhard, I see their maiden-names were used, but "Levi-Montalcini" may be incorrect

Replaced by Horst Feistel.

thaJeztah · 2018-06-30T18:27:09Z

Noticed she received the title "Dame", perhaps we should include that

thaJeztah · 2018-06-30T18:28:29Z

I see she's divorced, so perhaps we should list her under her maiden name https://en.m.wikipedia.org/wiki/Jocelyn_Bell_Burnell

That would conflict with bell from Alexander Graham Bell's surname.

Despite her divorce, Dame Jocelyn chooses to keep that surname. For example, she is the patron of the Burnell House in the Cambridge House Grammar School. Also a book co-edited by her as recently as in 2008 (she divorced Martin Burnell in 1993), retains Burnell in her name. So, I think burnell should be fine.

Alright, thanks or checking that

thaJeztah · 2018-06-30T18:29:56Z

Saw she carried the "Dame" title as well

debayande · 2018-07-01T13:59:31Z

@thaJeztah I've made the changes you requested. Please take a look. Thanks!

thaJeztah

LGTM, thanks!

Signed-off-by: Debayan De <debayande@users.noreply.github.com>

debayande · 2018-07-03T01:14:36Z

👆Just squashed two commits into one; no new deltas have been introduced.

vdemeester

LGTM 🐯

thaJeztah · 2018-07-05T19:06:26Z

Merged! Thanks for contributing @debayande !!

@jeking3

* Replaces `cocks` with `cerf` as the former might be perceived as offensive by some people (as pointed out by @jeking3 [here](moby#37157 (comment))) * Removes a duplicate entry for `burnell` * Re-arranges the entry for `sutherland` to ensure that the names are in sorted order * Adds entries for `shamir` and `wilbur` Signed-off-by: Debayan De <debayande@users.noreply.github.com>

@jeking3

* Replaces `cocks` with `cerf` as the former might be perceived as offensive by some people (as pointed out by @jeking3 [here](moby/moby#37157 (comment))) * Removes a duplicate entry for `burnell` * Re-arranges the entry for `sutherland` to ensure that the names are in sorted order * Adds entries for `shamir` and `wilbur` Signed-off-by: Debayan De <debayande@users.noreply.github.com> Upstream-commit: e50f791d42d1167a5ef757b1aa179e84f0f81bba Component: engine

@jeking3

* Replaces `cocks` with `cerf` as the former might be perceived as offensive by some people (as pointed out by @jeking3 [here](moby#37157 (comment))) * Removes a duplicate entry for `burnell` * Re-arranges the entry for `sutherland` to ensure that the names are in sorted order * Adds entries for `shamir` and `wilbur` Signed-off-by: Debayan De <debayande@users.noreply.github.com> (cherry picked from commit e50f791) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

@jeking3

* Replaces `cocks` with `cerf` as the former might be perceived as offensive by some people (as pointed out by @jeking3 [here](moby/moby#37157 (comment))) * Removes a duplicate entry for `burnell` * Re-arranges the entry for `sutherland` to ensure that the names are in sorted order * Adds entries for `shamir` and `wilbur` Signed-off-by: Debayan De <debayande@users.noreply.github.com> (cherry picked from commit e50f791d42d1167a5ef757b1aa179e84f0f81bba) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: a818442de73b16d8ad756c74e5e660d132e97848 Component: engine

@jeking3

* Replaces `cocks` with `cerf` as the former might be perceived as offensive by some people (as pointed out by @jeking3 [here](moby#37157 (comment))) * Removes a duplicate entry for `burnell` * Re-arranges the entry for `sutherland` to ensure that the names are in sorted order * Adds entries for `shamir` and `wilbur` Signed-off-by: Debayan De <debayande@users.noreply.github.com>

@jeking3

* Replaces `cocks` with `cerf` as the former might be perceived as offensive by some people (as pointed out by @jeking3 [here](moby/moby#37157 (comment))) * Removes a duplicate entry for `burnell` * Re-arranges the entry for `sutherland` to ensure that the names are in sorted order * Adds entries for `shamir` and `wilbur` Signed-off-by: Debayan De <debayande@users.noreply.github.com>

GordonTheTurtle added the status/0-triage label May 26, 2018

AkihiroSuda reviewed May 26, 2018

View reviewed changes

debayande force-pushed the even-more-names branch from e3e1832 to ba67872 Compare May 26, 2018 13:56

debayande force-pushed the even-more-names branch 3 times, most recently from 1c4e2b8 to 7649fbe Compare May 26, 2018 23:20

GordonTheTurtle assigned duglin Jun 10, 2018

vdemeester requested a review from thaJeztah June 13, 2018 07:13

vdemeester added status/2-code-review and removed status/0-triage labels Jun 13, 2018

debayande force-pushed the even-more-names branch 2 times, most recently from 840ff73 to fc09683 Compare June 28, 2018 10:33

thaJeztah requested changes Jun 30, 2018

View reviewed changes

debayande force-pushed the even-more-names branch from fc09683 to 02a7afa Compare July 1, 2018 13:54

debayande force-pushed the even-more-names branch from aa7c024 to 47926b7 Compare July 2, 2018 11:55

thaJeztah approved these changes Jul 2, 2018

View reviewed changes

Adds a few more names to the name generator.

9d61eee

Signed-off-by: Debayan De <debayande@users.noreply.github.com>

debayande force-pushed the even-more-names branch from 47926b7 to 9d61eee Compare July 3, 2018 01:13

vdemeester approved these changes Jul 3, 2018

View reviewed changes

thaJeztah added status/4-merge rebuild/janky and removed status/2-code-review labels Jul 3, 2018

GordonTheTurtle removed the rebuild/janky label Jul 3, 2018

thaJeztah merged commit 656036c into moby:master Jul 5, 2018

debayande deleted the even-more-names branch December 23, 2018 10:21

debayande mentioned this pull request Dec 23, 2018

Makes a few modifications to the name generator. #38422

Merged

thaJeztah mentioned this pull request Feb 20, 2019

[18.09 backport] Makes a few modifications to the name generator. docker-archive/engine#159

Merged

Conversation

debayande commented May 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented May 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

AkihiroSuda commented Jun 28, 2018

Uh oh!

debayande commented Jun 28, 2018

Uh oh!

AkihiroSuda commented Jun 29, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

debayande Jul 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

debayande commented Jul 1, 2018

Uh oh!

thaJeztah left a comment

Choose a reason for hiding this comment

Uh oh!

debayande commented Jul 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vdemeester left a comment

Choose a reason for hiding this comment

Uh oh!

thaJeztah commented Jul 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

debayande commented May 26, 2018 •

edited

Loading

codecov bot commented May 26, 2018 •

edited

Loading

debayande Jul 1, 2018 •

edited

Loading

debayande commented Jul 3, 2018 •

edited

Loading